From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263450AbVGATm3 (ORCPT ); Fri, 1 Jul 2005 15:42:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263457AbVGATmD (ORCPT ); Fri, 1 Jul 2005 15:42:03 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:2993 "EHLO parcelfarce.linux.theplanet.co.uk") by vger.kernel.org with ESMTP id S263443AbVGATjZ (ORCPT ); Fri, 1 Jul 2005 15:39:25 -0400 Date: Fri, 1 Jul 2005 11:49:01 -0300 From: Marcelo Tosatti To: Olivier Croquette Cc: Andrew Morton , torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: setitimer expire too early (Kernel 2.4) Message-ID: <20050701144901.GC11975@logos.cnet> References: <42C444AA.2070508@free.fr> <20050630165053.GA8220@logos.cnet> <20050630160537.7d05d467.akpm@osdl.org> <42C582CC.5050907@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42C582CC.5050907@free.fr> User-Agent: Mutt/1.5.5.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Olivier, On Fri, Jul 01, 2005 at 07:52:12PM +0200, Olivier Croquette wrote: > Andrew Morton wrote: > >>Linus, Andrew, do you consider this critical enough to be merged to > >>the v2.4 tree? > > > > > >No. I'd expect this would hurt more people than it would benefit. > > > Probably. > Does that mean that the kernel 2.4 will keep this bug for ever? Probably, yes. I've never heard such complaints before your message. The right way to do it seems something else BTW: quoting Nish Aravamudan (http://lkml.org/lkml/2005/4/29/240): Your patch is the only way to guarantee no early timeouts, as far as I know. Really, what you want is: on adding timers, take the ceiling of the interval into which it could be added on expiring timers, take the floor This combination guarantees no timers go off early (and takes away many of these corner cases). I do exactly this in my patch, btw.