atxp1 module not compiling

atxp1 module not compiling

[Sebastian Pigulak]

Hey,

I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:

LD      init/built-in.o
LD      vmlinux
drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
: undefined reference to `i2c_which_vrm'
drivers/built-in.o(.text+0x921ae): In function `atxp1_attach_adapter':
: undefined reference to `i2c_detect'
make: *** [vmlinux] Błąd 1
==> ERROR: Build Failed.  Aborting... 

Could someone have a look at the module and possibly fix it up?

----------------------------------------------------------------------
OMNIXMAIL! Jesli masz telefon w sieci Era i dostep do WAP, to mozesz
na komorce odbierac poczte ze wszystkich swoich kont poczty e-mail!
OMNIXMAIL jest w Era Omnix: http://link.interia.pl/f1896

[2.6 patch] SENSORS_ATXP1 must select I2C_SENSOR

[Adrian Bunk]

On Thu, Jun 30, 2005 at 11:47:09PM +0200, Sebastian Pigulak wrote:

> Hey,

Hi Sebastian,

> I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:
> 
> LD      init/built-in.o
> LD      vmlinux
> drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
> : undefined reference to `i2c_which_vrm'
> drivers/built-in.o(.text+0x921ae): In function `atxp1_attach_adapter':
> : undefined reference to `i2c_detect'
> make: *** [vmlinux] B??d 1
> ==> ERROR: Build Failed.  Aborting... 
> 
> Could someone have a look at the module and possibly fix it up?

The patch below should fix it.

cu
Adrian


<--  snip  -->


SENSORS_ATXP1 must select I2C_SENSOR.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-mm2-full/drivers/i2c/chips/Kconfig.old	2005-06-30 23:56:34.000000000 +0200
+++ linux-2.6.12-mm2-full/drivers/i2c/chips/Kconfig	2005-06-30 23:57:08.000000000 +0200
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.

[PATCH]Re: atxp1 module not compiling; needs I2C_SENSOR

[Prakash Punnoor]

[-- Attachment #1.1: Type: text/plain, Size: 1143 bytes --]

Sebastian Pigulak schrieb:
> Hey,
> 
> I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:
> 
> LD      init/built-in.o
> LD      vmlinux
> drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
> : undefined reference to `i2c_which_vrm'
> drivers/built-in.o(.text+0x921ae): In function `atxp1_attach_adapter':
> : undefined reference to `i2c_detect'
> make: *** [vmlinux] Błąd 1
> ==> ERROR: Build Failed.  Aborting... 
> 
> Could someone have a look at the module and possibly fix it up?

Try attached patch.  (Works fine for me then.)

Cheers,

Prakash

Signed-off-by: Prakash Punnoor <prakash@punnoor.de>

--- drivers/i2c/chips/Kconfig~	2005-06-29 11:06:01.000000000 +0200
+++ drivers/i2c/chips/Kconfig	2005-07-01 00:17:34.972426160 +0200
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.

[-- Attachment #1.2: atxp1_needs_i2c_sensor.diff --]
[-- Type: text/plain, Size: 359 bytes --]

--- drivers/i2c/chips/Kconfig~	2005-06-29 11:06:01.000000000 +0200
+++ drivers/i2c/chips/Kconfig	2005-07-01 00:17:34.972426160 +0200
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [2.6 patch] SENSORS_ATXP1 must select I2C_SENSOR

[Sebastian Pigulak]

On Fri, 1 Jul 2005 00:17:27 +0200
Adrian Bunk <bunk@stusta.de> wrote:

> On Thu, Jun 30, 2005 at 11:47:09PM +0200, Sebastian Pigulak wrote:
> 
> > Hey,
> 
> Hi Sebastian,
> 
> > I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:
> > 
> > LD      init/built-in.o
> > LD      vmlinux
> > drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
> > : undefined reference to `i2c_which_vrm'
> > drivers/built-in.o(.text+0x921ae): In function `atxp1_attach_adapter':
> > : undefined reference to `i2c_detect'
> > make: *** [vmlinux] B??d 1
> > ==> ERROR: Build Failed.  Aborting... 
> > 
> > Could someone have a look at the module and possibly fix it up?
> 
> The patch below should fix it.
> 
> cu
> Adrian
> 
> 
> <--  snip  -->
> 
> 
> SENSORS_ATXP1 must select I2C_SENSOR.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.12-mm2-full/drivers/i2c/chips/Kconfig.old	2005-06-30 23:56:34.000000000 +0200
> +++ linux-2.6.12-mm2-full/drivers/i2c/chips/Kconfig	2005-06-30 23:57:08.000000000 +0200
> @@ -80,6 +80,7 @@
>  config SENSORS_ATXP1
>  	tristate "Attansic ATXP1 VID controller"
>  	depends on I2C && EXPERIMENTAL
> +	select I2C_SENSOR
>  	help
>  	  If you say yes here you get support for the Attansic ATXP1 VID
>  	  controller.
> 

Thanks a lot for this patch. Now the kernel compiles just fine.

----------------------------------------------------------------------
Jak powstaje auto? >>> http://link.interia.pl/f1898

Re: [2.6 patch] SENSORS_ATXP1 must select I2C_SENSOR

[Jean Delvare]

Hi Adrian,

> > I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and
> > building atxp1(it allows Vcore voltage changing) into the kernel.
> > Unfortunately, the kernel compilation stops with:
> > 
> > LD      init/built-in.o
> > LD      vmlinux
> > drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
> > : undefined reference to `i2c_which_vrm'
> > drivers/built-in.o(.text+0x921ae): In function
> > `atxp1_attach_adapter': : undefined reference to `i2c_detect'
> > make: *** [vmlinux] B??d 1
> > ==> ERROR: Build Failed.  Aborting... 
> > 
> > Could someone have a look at the module and possibly fix it up?
> 
> The patch below should fix it.

Good catch. However, this fix will conflict with a larger patch I am
working on (moving hardware monitoring drivers to a different directory
[1]), so I applied a different fix on top of my own stack, and will send
all this stuff to Greg as soon as possible.

[1] http://lkml.org/lkml/2005/6/27/302

Thanks,
-- 
Jean Delvare