Re: [PATCH] securityfs

Greg KH
2005-07-08T20:51:33Z

On Fri, Jul 08, 2005 at 03:44:19PM -0500, serue@us.ibm.com wrote:
> Quoting Greg KH (greg@kroah.com):
> > On Thu, Jul 07, 2005 at 05:46:04PM -0500, serge@hallyn.com wrote:
> > >
> > > With the obvious fix, that does in fact work (patch appended).
> >
> > Good.
> >
> > > The __simple_attr_check_format problem remains however. I assume we
> > > don't really want to just take it out, though, like this patch does?
> >
> > No we do not.
> >
> > > The error I get without the fs.h patch is:
> > >
> > > security/seclvl.c: In function `seclvl_file_ops_open':
> > > security/seclvl.c:186: warning: int format, different type arg (arg 2)
> >
> > Care to work to try to fix it up?
>
> Once again, the simple_attr in libfs was actually sufficient - I'd
> thought the __attribute__(format(printk(1,2))) was more mysterious than
> it really is.
>
> At last, here is the full patch to make seclvl use securityfs.
>
> thanks,
> -serge
>
> Signed-off-by: Serge Hallyn <serue@us.ibm.com>
> --
> seclvl.c | 228 +++++++++++++++++++--------------------------------------------
> 1 files changed, 70 insertions(+), 158 deletions(-)

Very nice, it's always good to end up removing lines of code :)

thanks for verifying that it all works properly.

Chris, care to forward the securityfs patch to Linus?

thanks,

greg k-h