Re: [PATCH] securityfs

Greg KH
2005-07-05T06:08:55Z

On Mon, Jul 04, 2005 at 10:53:21AM -0500, serge@hallyn.com wrote:
> > On Sun, Jul 03, 2005 at 02:53:17PM -0400, James Morris wrote:
> > > On Sun, 3 Jul 2005, Tony Jones wrote:
> > >
> > > > There just isn't enough content to justify a stacker specific filesystem IMHO.
> > >
> > > It might be worth thinking about a more general securityfs as part of LSM,
> > > to be used by stacker and LSM modules. SELinux could use this instead of
> > > managing its own selinuxfs.
> >
> > Good idea. Here's a patch to do just that (compile tested only...)
> >
> > Comments?
>
> Tested without a hitch.

Thanks for testing.

> In addition, the attached patch converts seclvl to use the securityfs.
> Also tested without any problems. (Only meant as proof of concept:
> Mike, you'll probably want to at least add the passwd_read_file
> function back in, I assume?)
>
> --
> seclvl.c | 226 > +++++++++++++++++++++++++++------------------------------------
> 1 files changed, 99 insertions(+), 127 deletions(-)

Nice, glad to see this makes your code smaller and simpler. Although I
think it could be made even smaller if you use the default read and
write file type functions in libfs (look at the debugfs wrappers of them
for u8, u16, etc, for examples of how to use them.)

thanks,

greg k-h