public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH]Fix menuconfig error message
@ 2005-07-04 13:57 Kurt Wall
  2005-07-04 15:16 ` David Weinehall
  0 siblings, 1 reply; 5+ messages in thread
From: Kurt Wall @ 2005-07-04 13:57 UTC (permalink / raw)
  To: linux-kernel, kbuild-devel, zippel

If you try to run `make menuconfig' on a system that lacks ncurses
development libs, you get an error message telling you to install
ncurses-devel. Some popular distributions don't have an ncurses-devel
package. This patch generalizes the error message. Patch is against
2.6.12.

MAINTAINERS doesn't list a maintainer for menuconfig or lxdialog,
so I sent this to lkml, kbuild-devel, and to the kconfig maintainer.

Signed-off-by: Kurt Wall <kwall@kurtwerks.com>


--- a/scripts/lxdialog/Makefile	2005-07-04 09:31:38.000000000 -0400
+++ b/scripts/lxdialog/Makefile	2005-07-04 09:38:05.000000000 -0400
@@ -35,8 +35,10 @@
 		echo -e "\007" ;\
 		echo ">> Unable to find the Ncurses libraries." ;\
 		echo ">>" ;\
-		echo ">> You must install ncurses-devel in order" ;\
-		echo ">> to use 'make menuconfig'" ;\
+		echo ">> You must install ncurses development libraries" ;\
+		echo ">> to use 'make menuconfig'. If you have an RPM-based" ;\
+		echo ">> Debian-based distribution you should install the" ;\ 
+		echo ">> ncurses-devel package." ;\
 		echo ;\
 		exit 1 ;\
 	fi


Kurt
-- 
"I have a very firm grasp on reality!  I can reach out and strangle it
any time!"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH]Fix menuconfig error message
  2005-07-04 13:57 [PATCH]Fix menuconfig error message Kurt Wall
@ 2005-07-04 15:16 ` David Weinehall
  2005-07-04 15:46   ` Kurt Wall
  0 siblings, 1 reply; 5+ messages in thread
From: David Weinehall @ 2005-07-04 15:16 UTC (permalink / raw)
  To: linux-kernel, kbuild-devel, zippel

On Mon, Jul 04, 2005 at 09:57:00AM -0400, Kurt Wall wrote:
> If you try to run `make menuconfig' on a system that lacks ncurses
> development libs, you get an error message telling you to install
> ncurses-devel. Some popular distributions don't have an ncurses-devel
> package. This patch generalizes the error message. Patch is against
> 2.6.12.
> 
> MAINTAINERS doesn't list a maintainer for menuconfig or lxdialog,
> so I sent this to lkml, kbuild-devel, and to the kconfig maintainer.
> 
> Signed-off-by: Kurt Wall <kwall@kurtwerks.com>
> 
> 
> --- a/scripts/lxdialog/Makefile	2005-07-04 09:31:38.000000000 -0400
> +++ b/scripts/lxdialog/Makefile	2005-07-04 09:38:05.000000000 -0400
> @@ -35,8 +35,10 @@
>  		echo -e "\007" ;\
>  		echo ">> Unable to find the Ncurses libraries." ;\
>  		echo ">>" ;\
> -		echo ">> You must install ncurses-devel in order" ;\
> -		echo ">> to use 'make menuconfig'" ;\
> +		echo ">> You must install ncurses development libraries" ;\
> +		echo ">> to use 'make menuconfig'. If you have an RPM-based" ;\
> +		echo ">> Debian-based distribution you should install the" ;\ 
> +		echo ">> ncurses-devel package." ;\
>  		echo ;\
>  		exit 1 ;\
>  	fi

You know, I'd say that *very* few (approximately zero)
Debian-based distributions are RPM-based =)  The Debian package is
called libncurses5-dev, btw.


Regards: David Weinehall
-- 
 /) David Weinehall <tao@acc.umu.se> /) Northern lights wander      (\
//  Maintainer of the v2.0 kernel   //  Dance across the winter sky //
\)  http://www.acc.umu.se/~tao/    (/   Full colour fire           (/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH]Fix menuconfig error message
  2005-07-04 15:16 ` David Weinehall
@ 2005-07-04 15:46   ` Kurt Wall
  0 siblings, 0 replies; 5+ messages in thread
From: Kurt Wall @ 2005-07-04 15:46 UTC (permalink / raw)
  To: linux-kernel; +Cc: kbuild-devel, zippel

On Mon, Jul 04, 2005 at 05:16:32PM +0200, David Weinehall wrote:
> On Mon, Jul 04, 2005 at 09:57:00AM -0400, Kurt Wall wrote:
> > If you try to run `make menuconfig' on a system that lacks ncurses
> > development libs, you get an error message telling you to install
> > ncurses-devel. Some popular distributions don't have an ncurses-devel
> > package. This patch generalizes the error message. Patch is against
> > 2.6.12.

[...]

> > +		echo ">> to use 'make menuconfig'. If you have an RPM-based" ;\
> > +		echo ">> Debian-based distribution you should install the" ;\ 
> > +		echo ">> ncurses-devel package." ;\
> >  		echo ;\
> >  		exit 1 ;\
> >  	fi
> 
> You know, I'd say that *very* few (approximately zero)
> Debian-based distributions are RPM-based =)  The Debian package is
> called libncurses5-dev, btw.

Silly typo. I'll post a new patch with the Debian package name.
Thanks.

Kurt
-- 
Bradley's Bromide:
	If computers get too powerful, we can organize them into a
committee -- that will do them in.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH]Fix menuconfig error message
@ 2005-07-04 15:53 Kurt Wall
  2005-07-04 18:32 ` Roman Zippel
  0 siblings, 1 reply; 5+ messages in thread
From: Kurt Wall @ 2005-07-04 15:53 UTC (permalink / raw)
  To: linux-kernel, zippel, kbuild-devel

If you try to run `make menuconfig' on a system that lacks ncurses
development libs, you get an error message telling you to install
ncurses-devel. Some popular distributions don't have an ncurses-devel
package. This patch generalizes the error message. Patch is against
2.6.12.

This patch fixes a silly typo conflating RPM-based systems with Debian
derivatives and adds the name of the Debian package to install.

MAINTAINERS doesn't list a maintainer for menuconfig or lxdialog,
so I sent this to lkml, kbuild-devel, and to the kconfig maintainer.

Signed-off-by: Kurt Wall <kwall@kurtwerks.com>


--- a/scripts/lxdialog/Makefile	2005-07-04 09:54:44.000000000 -0400
+++ b/scripts/lxdialog/Makefile	2005-07-04 11:50:00.000000000 -0400
@@ -35,8 +35,11 @@
 		echo -e "\007" ;\
 		echo ">> Unable to find the Ncurses libraries." ;\
 		echo ">>" ;\
-		echo ">> You must install ncurses-devel in order" ;\
-		echo ">> to use 'make menuconfig'" ;\
+		echo ">> You must install ncurses development libraries" ;\
+		echo ">> to use 'make menuconfig'. If you have an RPM-based" ;\
+		echo ">> distribution you should install the ncurses-devel" ;\
+		echo ">> Debian users will probably want to install the
+		echo ">> libncurses5-dev package." ;\
 		echo ;\
 		exit 1 ;\
 	fi
-- 
Rule of Feline Frustration:
	When your cat has fallen asleep on your lap and looks utterly
content and adorable, you will suddenly have to go to the bathroom.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH]Fix menuconfig error message
  2005-07-04 15:53 Kurt Wall
@ 2005-07-04 18:32 ` Roman Zippel
  0 siblings, 0 replies; 5+ messages in thread
From: Roman Zippel @ 2005-07-04 18:32 UTC (permalink / raw)
  To: Kurt Wall; +Cc: linux-kernel, kbuild-devel

Hi,

On Mon, 4 Jul 2005, Kurt Wall wrote:

> --- a/scripts/lxdialog/Makefile	2005-07-04 09:54:44.000000000 -0400
> +++ b/scripts/lxdialog/Makefile	2005-07-04 11:50:00.000000000 -0400
> @@ -35,8 +35,11 @@
>  		echo -e "\007" ;\
>  		echo ">> Unable to find the Ncurses libraries." ;\
>  		echo ">>" ;\
> -		echo ">> You must install ncurses-devel in order" ;\
> -		echo ">> to use 'make menuconfig'" ;\
> +		echo ">> You must install ncurses development libraries" ;\
> +		echo ">> to use 'make menuconfig'. If you have an RPM-based" ;\
> +		echo ">> distribution you should install the ncurses-devel" ;\
> +		echo ">> Debian users will probably want to install the
> +		echo ">> libncurses5-dev package." ;\
>  		echo ;\
>  		exit 1 ;\
>  	fi

I would prefer if we don't mention special distributions or version 
numbers and just mentioned a few common package names.
On Debian libncurses-dev or ncurses-dev works as well and so is better 
than libncurses5-dev.

bye, Roman

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2005-07-04 18:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-04 13:57 [PATCH]Fix menuconfig error message Kurt Wall
2005-07-04 15:16 ` David Weinehall
2005-07-04 15:46   ` Kurt Wall
  -- strict thread matches above, loose matches on Subject: below --
2005-07-04 15:53 Kurt Wall
2005-07-04 18:32 ` Roman Zippel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox