From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261914AbVGER7X (ORCPT ); Tue, 5 Jul 2005 13:59:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261930AbVGER7X (ORCPT ); Tue, 5 Jul 2005 13:59:23 -0400 Received: from smtp104.rog.mail.re2.yahoo.com ([206.190.36.82]:9328 "HELO smtp104.rog.mail.re2.yahoo.com") by vger.kernel.org with SMTP id S261914AbVGER7P (ORCPT ); Tue, 5 Jul 2005 13:59:15 -0400 Date: Tue, 5 Jul 2005 14:07:12 -0400 To: Anton Altaparmakov Cc: Daniel Drake , David G?mez , Robert Love , Linux-kernel Subject: Re: Problem with inotify Message-ID: <20050705180711.GA17429@tentacle.dhs.org> References: <42C72563.7040103@gentoo.org> <42C7BF37.9010005@gentoo.org> <1120487242.11399.5.camel@imp.csi.cam.ac.uk> <42C9788F.50205@gentoo.org> <1120527203.18268.2.camel@vertex> <20050705154837.GA16512@tentacle.dhs.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i From: John McCutchan Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 05, 2005 at 06:06:56PM +0100, Anton Altaparmakov wrote: > On Tue, 5 Jul 2005, John McCutchan wrote: > > On Tue, Jul 05, 2005 at 08:56:15AM +0100, Anton Altaparmakov wrote: > > > On Mon, 4 Jul 2005, John McCutchan wrote: > > > > On Mon, 2005-07-04 at 20:09 +0100, Anton Altaparmakov wrote: > > > > > On Mon, 4 Jul 2005, Daniel Drake wrote: > > > > > > Anton Altaparmakov wrote: > > > > > > > )-: I have addressed the only things I can think off that could cause > > > > > > > the oops and below is the resulting patch. Could you please test it? > > > > > > > > > > > > Yeah!! After removing I_WILL_FREE stuff, that fixed both the oops *and* the > > > > > > hang. Everything works nicely now. > > > > > > > > > > Great! Thanks a lot for testing! I will send a patch to Robert and > > > > > Andrew in a minute with more comments added. > > > > > > > > Nice work, I am going to have a closer look at the patch soon. Could you > > > > post the final patch at http://bugzilla.kernel.org/show_bug.cgi?id=4796 > > > > > > Thanks. Now done. But I am not sure about the white space. I can't get > > > anything sensible out of IE on Mac OS 9 which I am on at the moment. > > > > Originally inotify had 2 functions that handled this. One that would > > build up a list of inodes to call remove_watch on, the other function > > would do the actual calling of remove_watch. This mirrored the other > > unmount paths. I'm wondering if it wouldn't be cleaner to revert back to > > that way? > > That is certainly possible. Out of curiosity, how did you anchor the > inodes to your private list? Or did you just have a dynamically allocated > array of pointers to inodes? > The only reason I suggested it, is I'm afraid that maybe we are still missing a corner case. Even with your fix. We just added a new list_head in the inode struct. If you look at older versions of inotify, maybe around 0.15 you can see for yourself. John