* [PATCH -mm] iteraid: remove ITE_IOC_GET_DRIVER_VERSION
@ 2005-07-05 19:24 Alexey Dobriyan
2005-07-06 9:00 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2005-07-05 19:24 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Donald.Huang
Until too late.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
diff -uprN linux-2.6.13-rc1-mm1/drivers/scsi/iteraid.c linux-2.6.13-rc1-mm1-iteraid/drivers/scsi/iteraid.c
--- linux-2.6.13-rc1-mm1/drivers/scsi/iteraid.c 2005-07-03 04:13:08.000000000 +0400
+++ linux-2.6.13-rc1-mm1-iteraid/drivers/scsi/iteraid.c 2005-07-05 23:12:31.000000000 +0400
@@ -301,7 +301,7 @@ static int itedev_ioctl(struct inode *,
static int itedev_close(struct inode *, struct file *);
#define DRV_VER_8212 "1.45"
-static int driver_ver = 145;
+MODULE_VERSION(DRV_VER_8212);
static int ite_major = 0;
static struct file_operations itedev_fops = {
@@ -5112,11 +5112,6 @@ exit:
put_user(status, (u8 __user *) arg);
return 0;
- case ITE_IOC_GET_DRIVER_VERSION:
- dprintk("ITE_IOC_GET_DRIVER_VERSION\n");
-
- put_user(driver_ver, (int __user *)arg);
- return 0;
default:
return -EINVAL;
} /* end switch */
diff -uprN linux-2.6.13-rc1-mm1/drivers/scsi/iteraid.h linux-2.6.13-rc1-mm1-iteraid/drivers/scsi/iteraid.h
--- linux-2.6.13-rc1-mm1/drivers/scsi/iteraid.h 2005-07-03 04:13:08.000000000 +0400
+++ linux-2.6.13-rc1-mm1-iteraid/drivers/scsi/iteraid.h 2005-07-05 23:10:18.000000000 +0400
@@ -988,7 +988,6 @@ typedef struct _uioctl_t {
#define ITE_IOC_REBUILD_START _IO(ITE_IOCMAGIC, 3)
#define ITE_IOC_GET_REBUILD_STATUS _IO(ITE_IOCMAGIC, 4)
#define ITE_IOC_RESET_ADAPTER _IO(ITE_IOCMAGIC, 5)
-#define ITE_IOC_GET_DRIVER_VERSION _IO(ITE_IOCMAGIC, 6)
typedef struct _Channel {
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -mm] iteraid: remove ITE_IOC_GET_DRIVER_VERSION
2005-07-05 19:24 [PATCH -mm] iteraid: remove ITE_IOC_GET_DRIVER_VERSION Alexey Dobriyan
@ 2005-07-06 9:00 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2005-07-06 9:00 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, linux-kernel, Donald.Huang
We can just kill the driver again, mainline now has the proper ide-layer
driver for the hardware. The scsi-layer driver is not going in with any
amount of cleanups, it's just conceptually wrong.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-06 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-05 19:24 [PATCH -mm] iteraid: remove ITE_IOC_GET_DRIVER_VERSION Alexey Dobriyan
2005-07-06 9:00 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox