public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: linux-ide@vger.kernel.org, torvalds@osdl.org,
	linux-kernel@vger.kernel.org, christoph@lameter.com
Subject: [PATCH] Fix crash on boot in kmalloc_node IDE changes
Date: Wed, 6 Jul 2005 15:30:53 +0200	[thread overview]
Message-ID: <20050706133052.GF21330@wotan.suse.de> (raw)


Without this patch a dual Xeon EM64T machine would oops on boot
because the hwif pointer here was NULL. I also added a check for
pci_dev because it's doubtful that all IDE devices have pci_devs.

Signed-off-by: Andi Kleen <ak@suse.de>


Index: linux/drivers/ide/ide-probe.c
===================================================================
--- linux.orig/drivers/ide/ide-probe.c
+++ linux/drivers/ide/ide-probe.c
@@ -978,8 +978,10 @@ static int ide_init_queue(ide_drive_t *d
 	 *	do not.
 	 */
 
-	q = blk_init_queue_node(do_ide_request, &ide_lock,
-				pcibus_to_node(drive->hwif->pci_dev->bus));
+	int node = 0; /* Should be -1 */
+	if (drive->hwif && drive->hwif->pci_dev)
+		node = pcibus_to_node(drive->hwif->pci_dev->bus); 
+	q = blk_init_queue_node(do_ide_request, &ide_lock, node);
 	if (!q)
 		return 1;
 
@@ -1096,8 +1098,13 @@ static int init_irq (ide_hwif_t *hwif)
 		hwgroup->hwif->next = hwif;
 		spin_unlock_irq(&ide_lock);
 	} else {
-		hwgroup = kmalloc_node(sizeof(ide_hwgroup_t), GFP_KERNEL,
-			pcibus_to_node(hwif->drives[0].hwif->pci_dev->bus));
+		int node = 0; 
+		if (hwif->drives[0].hwif) { 
+			struct pci_dev *pdev = hwif->drives[0].hwif->pci_dev;  
+			if (pdev)
+				node = pcibus_to_node(pdev->bus);
+		}
+		hwgroup = kmalloc_node(sizeof(ide_hwgroup_t), GFP_KERNEL,node);
 		if (!hwgroup)
 	       		goto out_up;
 



             reply	other threads:[~2005-07-06 18:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-06 13:30 Andi Kleen [this message]
2005-07-06 14:05 ` [PATCH] Fix crash on boot in kmalloc_node IDE changes Bartlomiej Zolnierkiewicz
2005-07-06 14:09   ` Andi Kleen
2005-07-06 14:35     ` Bartlomiej Zolnierkiewicz
2005-07-06 18:21       ` Andi Kleen
2005-07-06 16:34 ` Christoph Lameter
2005-07-06 16:45   ` Andi Kleen
2005-07-06 17:07     ` Christoph Lameter
2005-07-07 16:21 ` [another PATCH] " Christoph Lameter
2005-07-07 16:24   ` Andi Kleen
2005-07-07 16:32     ` Christoph Lameter
2005-07-07 16:36       ` Andi Kleen
2005-07-07 17:15         ` Christoph Lameter
2005-07-07 16:46       ` Bartlomiej Zolnierkiewicz
2005-07-07 16:38   ` Linus Torvalds
2005-07-07 16:40     ` Andi Kleen
2005-07-07 17:23     ` Christoph Lameter
2005-07-07 17:31       ` Jens Axboe
2005-07-07 18:57       ` Linus Torvalds
2005-07-07 19:09         ` Christoph Lameter
2005-07-07 21:15           ` Andi Kleen
2005-07-07 21:19             ` Bartlomiej Zolnierkiewicz
2005-07-07 21:25               ` Andi Kleen
2005-07-08  4:44                 ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050706133052.GF21330@wotan.suse.de \
    --to=ak@suse.de \
    --cc=christoph@lameter.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox