From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Eyal Lebedinsky <eyal@eyal.emu.id.au>,
Matthias Andree <matthias.andree@gmx.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.13-rc2
Date: Wed, 6 Jul 2005 08:51:03 -0700 [thread overview]
Message-ID: <20050706155103.GA13115@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0507060837510.3570@g5.osdl.org>
On Wed, Jul 06, 2005 at 08:42:16AM -0700, Linus Torvalds wrote:
>
>
> On Wed, 6 Jul 2005, Eyal Lebedinsky wrote:
> >
> > CC [M] sound/pci/bt87x.o
> > sound/pci/bt87x.c: In function `snd_bt87x_detect_card':
> > sound/pci/bt87x.c:807: error: `driver' undeclared (first use in this function)
> > sound/pci/bt87x.c:807: error: (Each undeclared identifier is reported only once
> > sound/pci/bt87x.c:807: error: for each function it appears in.)
> > sound/pci/bt87x.c: At top level:
> > sound/pci/bt87x.c:910: error: `driver' used prior to declaration
>
> This seems to be a thinko by Greg. That line got changed from
>
> supported = pci_match_device(snd_bt87x_ids, pci);
>
> to
>
> supported = pci_match_device(driver, pci);
>
> but as far as I can tell it _should_ be
>
> supported = pci_match_id(snd_bt87x_ids, pci);
No, I wanted it to be "driver", but forgot to build the code, sorry.
Try the following patch instead:
thanks,
greg k-h
-------------------
Fixes bt87x.c build problem.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
sound/pci/bt87x.c | 2 ++
1 files changed, 2 insertions(+)
--- gregkh-2.6.orig/sound/pci/bt87x.c 2005-07-06 08:48:29.000000000 -0700
+++ gregkh-2.6/sound/pci/bt87x.c 2005-07-06 08:48:54.000000000 -0700
@@ -798,6 +798,8 @@
{0x270f, 0xfc00}, /* Chaintech Digitop DST-1000 DVB-S */
};
+static struct pci_driver driver;
+
/* return the rate of the card, or a negative value if it's blacklisted */
static int __devinit snd_bt87x_detect_card(struct pci_dev *pci)
{
next prev parent reply other threads:[~2005-07-06 19:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-06 4:32 Linux 2.6.13-rc2 Linus Torvalds
2005-07-06 6:56 ` Jan Dittmer
2005-07-06 9:09 ` Linux 2.6.13-rc2 - Inconsistent kallsyms data Alexis Ballier
2005-07-06 13:45 ` Paulo Marques
2005-07-06 14:52 ` Alexis Ballier
2005-07-07 11:51 ` Paulo Marques
2005-07-06 15:33 ` Linux 2.6.13-rc2 Linus Torvalds
2005-07-06 15:53 ` Jan Dittmer
2005-07-06 15:55 ` Greg KH
2005-07-06 7:35 ` Matt Mackall
2005-07-06 8:59 ` Florian Weimer
2005-07-06 12:18 ` Paolo Ciarrocchi
2005-07-06 9:10 ` compilation error sound/pci/bt87x.c:807 [Re: Linux 2.6.13-rc2] Tomasz Torcz
2005-07-06 14:35 ` Alexandre Buisse
2005-07-06 9:28 ` Linux 2.6.13-rc2: PCMCIA problem on AMD64 Rafael J. Wysocki
2005-07-06 16:47 ` Greg KH
2005-07-06 17:16 ` Linus Torvalds
2005-07-06 20:36 ` Rafael J. Wysocki
2005-07-06 20:33 ` Rafael J. Wysocki
2005-07-06 21:43 ` Ivan Kokshaysky
2005-07-06 22:15 ` Rafael J. Wysocki
2005-07-06 23:01 ` Ivan Kokshaysky
2005-07-06 9:37 ` Linux 2.6.13-rc2 Eyal Lebedinsky
2005-07-06 15:42 ` Linus Torvalds
2005-07-06 15:51 ` Greg KH [this message]
2005-07-06 16:22 ` Linus Torvalds
2005-07-06 16:27 ` Greg KH
2005-07-07 9:46 ` Takashi Iwai
2005-07-07 18:39 ` Greg KH
2005-07-07 19:57 ` Takashi Iwai
2005-07-06 10:29 ` Matthias Andree
2005-07-06 10:30 ` Matthias Andree
2005-07-06 15:58 ` Linux 2.6.13-rc2 (build error with no CONFIG_HOTPLUG_PCI) Steven Cole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050706155103.GA13115@kroah.com \
--to=greg@kroah.com \
--cc=eyal@eyal.emu.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.andree@gmx.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox