From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262345AbVGGAXC (ORCPT ); Wed, 6 Jul 2005 20:23:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262191AbVGFT7l (ORCPT ); Wed, 6 Jul 2005 15:59:41 -0400 Received: from mail.kroah.org ([69.55.234.183]:62916 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S262248AbVGFQ1X (ORCPT ); Wed, 6 Jul 2005 12:27:23 -0400 Date: Wed, 6 Jul 2005 09:27:10 -0700 From: Greg KH To: Linus Torvalds Cc: Eyal Lebedinsky , Matthias Andree , Linux Kernel Mailing List Subject: Re: Linux 2.6.13-rc2 Message-ID: <20050706162710.GC13777@kroah.com> References: <42CBA650.8080004@eyal.emu.id.au> <20050706155103.GA13115@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2005 at 09:22:05AM -0700, Linus Torvalds wrote: > > > On Wed, 6 Jul 2005, Greg KH wrote: > > > > --- gregkh-2.6.orig/sound/pci/bt87x.c 2005-07-06 08:48:29.000000000 -0700 > > +++ gregkh-2.6/sound/pci/bt87x.c 2005-07-06 08:48:54.000000000 -0700 > > @@ -798,6 +798,8 @@ > > {0x270f, 0xfc00}, /* Chaintech Digitop DST-1000 DVB-S */ > > }; > > > > +static struct pci_driver driver; > > + > > Hmm.. Shouldn't you at a _minimum_ initialize the name and owner fields? It's done so a few functions down. This is just a "forward" reference to the real thing there. thanks, greg k-h