public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] Fix bt87x.c build problem
Date: Wed, 6 Jul 2005 15:29:09 -0400	[thread overview]
Message-ID: <20050706192909.GA23293@redhat.com> (raw)
In-Reply-To: <200507061824.j66IODbD018395@hera.kernel.org>

On Wed, Jul 06, 2005 at 11:24:13AM -0700, Linux Kernel wrote:
 > tree 2fe5cb66de97b707e23d531578dc2a656855415e
 > parent 3d3c2ae1101c1f2dff7e2f9d514769779dbd2737
 > author Greg KH <greg@kroah.com> Wed, 06 Jul 2005 22:51:03 -0700
 > committer Linus Torvalds <torvalds@g5.osdl.org> Wed, 06 Jul 2005 23:34:23 -0700
 > 
 > [PATCH] Fix bt87x.c build problem
 > 
 > Missing forward declaration
 > 
 > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
 > Signed-off-by: Linus Torvalds <torvalds@osdl.org>
 > 
 >  sound/pci/bt87x.c |    2 ++
 >  1 files changed, 2 insertions(+)
 > 
 > diff --git a/sound/pci/bt87x.c b/sound/pci/bt87x.c
 > --- a/sound/pci/bt87x.c
 > +++ b/sound/pci/bt87x.c
 > @@ -798,6 +798,8 @@ static struct {
 >  	{0x270f, 0xfc00}, /* Chaintech Digitop DST-1000 DVB-S */
 >  };
 >  
 > +static struct pci_driver driver;
 > +
 >  /* return the rate of the card, or a negative value if it's blacklisted */
 >  static int __devinit snd_bt87x_detect_card(struct pci_dev *pci)
 >  {
 > -

Still not enough to make it build here..

sound/pci/bt87x.c:809: error: incompatible type for argument 1 of 'pci_match_device'

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.12/sound/pci/bt87x.c~	2005-07-06 14:59:08.000000000 -0400
+++ linux-2.6.12/sound/pci/bt87x.c	2005-07-06 15:26:35.000000000 -0400
@@ -806,7 +806,7 @@ static int __devinit snd_bt87x_detect_ca
 	int i;
 	const struct pci_device_id *supported;
 
-	supported = pci_match_device(driver, pci);
+	supported = pci_match_device(&driver, pci);
 	if (supported)
 		return supported->driver_data;
 

           reply	other threads:[~2005-07-06 20:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200507061824.j66IODbD018395@hera.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050706192909.GA23293@redhat.com \
    --to=davej@redhat.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox