From: Doug Warzecha <Douglas_Warzecha@dell.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: Add Dell Systems Management Base driver
Date: Wed, 6 Jul 2005 18:41:19 -0500 [thread overview]
Message-ID: <20050706234119.GA5949@sysman-doug.us.dell.com> (raw)
In-Reply-To: <20050706160737.GC13115@kroah.com>
On Wed, Jul 06, 2005 at 09:07:37AM -0700, Greg KH wrote:
> On Wed, Jul 06, 2005 at 10:57:35AM -0500, Doug Warzecha wrote:
> > On Tue, Jul 05, 2005 at 11:17:03PM -0500, Greg KH wrote:
> > > > +static void dcdbas_device_release(struct device *dev)
> > > > +{
> > > > + /* nothing to release */
> > > > +}
> > >
> > > This is a symptom of a broken driver.
> > >
> > > Hm, I wonder if there's some way for the compiler to check the fact that
> > > a function pointer passed to another function, is really a null
> > > function. That would stop this kind of nonsense...
> >
> > There are other drivers in the kernel tree with null device release functions.
>
> Where?
Here's a couple:
drivers/video/vfb.c: vfb_platform_release
drivers/video/epson1355fb.c: epson1355fb_platform_release
Doug
next prev parent reply other threads:[~2005-07-06 23:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-06 0:13 [PATCH] char: Add Dell Systems Management Base driver Doug Warzecha
2005-07-06 0:53 ` Chris Wedgwood
2005-07-12 23:17 ` Doug Warzecha
2005-07-14 21:04 ` Pavel Machek
2005-07-17 3:24 ` Chris Wedgwood
2005-07-06 1:02 ` randy_dunlap
2005-07-06 4:17 ` Greg KH
2005-07-06 15:57 ` Doug Warzecha
2005-07-06 16:07 ` Greg KH
2005-07-06 23:41 ` Doug Warzecha [this message]
2005-07-06 23:40 ` Greg KH
2005-07-13 0:57 ` Doug Warzecha
2005-07-13 20:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050706234119.GA5949@sysman-doug.us.dell.com \
--to=douglas_warzecha@dell.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox