device_find broken in 2.6.11?

device_find broken in 2.6.11?

[Rusty Russell]

Hi Greg,

	I was getting oopses in kset_find_obj when calling device_find in
2.6.11.12.  Noone else in the kernel uses device_find, but I couldnt'
see anything wrong with it (mind you, I can't understand the
kset_find_obj code to judge it).

	Iterating manually using bus_for_each_dev works though.

Known problem?
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

Re: device_find broken in 2.6.11?

[Greg KH]

On Fri, Jul 08, 2005 at 02:16:53PM +1000, Rusty Russell wrote:
> Hi Greg,
> 
> 	I was getting oopses in kset_find_obj when calling device_find in
> 2.6.11.12.  Noone else in the kernel uses device_find, but I couldnt'
> see anything wrong with it (mind you, I can't understand the
> kset_find_obj code to judge it).
> 
> 	Iterating manually using bus_for_each_dev works though.
> 
> Known problem?

Yup, there's a reason no one uses it.  Use the version in 2.6.13-rc2, it
actually works.

What are you wanting to use it for?

thanks,

greg k-h

Re: device_find broken in 2.6.11?

[Rusty Russell]

On Thu, 2005-07-07 at 21:29 -0700, Greg KH wrote:
> On Fri, Jul 08, 2005 at 02:16:53PM +1000, Rusty Russell wrote:
> > 
> > 	I was getting oopses in kset_find_obj when calling device_find in
> > 2.6.11.12.
> 
> Yup, there's a reason no one uses it.  Use the version in 2.6.13-rc2, it
> actually works.
> 
> What are you wanting to use it for?

The xenbus code wants to find if a device is new: the Xen code is
currently against on 2.6.11.12.

Thanks!
Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman

Re: device_find broken in 2.6.11?

[Greg KH]

On Sat, Jul 09, 2005 at 01:36:04AM +1000, Rusty Russell wrote:
> On Thu, 2005-07-07 at 21:29 -0700, Greg KH wrote:
> > On Fri, Jul 08, 2005 at 02:16:53PM +1000, Rusty Russell wrote:
> > > 
> > > 	I was getting oopses in kset_find_obj when calling device_find in
> > > 2.6.11.12.
> > 
> > Yup, there's a reason no one uses it.  Use the version in 2.6.13-rc2, it
> > actually works.
> > 
> > What are you wanting to use it for?
> 
> The xenbus code

What is that?  Any pointers to it?

> wants to find if a device is new:

new to whom?  Busses usually drive the finding of new devices, so they
always know when a device has been found or goes away.

> the Xen code is currently against on 2.6.11.12.

If you have code that is using the driver core, it will need big changes
for 2.6.13 due to the internal rework that we have done.  I suggest you
start now :)

Good luck,

greg k-h