Re: [PATCH] implicit declaration of function `page_cache_release'

Andrew Morton
2005-07-08T20:34:50Z

Olaf Hering <olh@suse.de> wrote:
>
>
> In file included from include2/asm/tlb.h:31,
> from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
>
> Signed-off-by: Olaf Hering <olh@suse.de>
>
> include/linux/pagemap.h | 2 +-
> include/linux/swap.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.13-rc2-olh/include/linux/pagemap.h
> ===================================================================
> --- linux-2.6.13-rc2-olh.orig/include/linux/pagemap.h
> +++ linux-2.6.13-rc2-olh/include/linux/pagemap.h
> @@ -48,7 +48,7 @@ static inline void mapping_set_gfp_mask(
>
> #define page_cache_get(page) get_page(page)
> #define page_cache_release(page) put_page(page)
> -void release_pages(struct page **pages, int nr, int cold);
> +extern void release_pages(struct page **pages, int nr, int cold);

Why this change? I think that was just me saving disk space.

> static inline struct page *page_cache_alloc(struct address_space *x)
> {
> Index: linux-2.6.13-rc2-olh/include/linux/swap.h
> ===================================================================
> --- linux-2.6.13-rc2-olh.orig/include/linux/swap.h
> +++ linux-2.6.13-rc2-olh/include/linux/swap.h
> @@ -7,6 +7,7 @@
> #include <linux/mmzone.h>
> #include <linux/list.h>
> #include <linux/sched.h>
> +#include <linux/pagemap.h>
> #include <asm/atomic.h>
> #include <asm/page.h>
>

Yup.