public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: akpm@osdl.org
Cc: Bernhard Rosenkraenzer <bero@arklinux.org>,
	linux-kernel@vger.kernel.org, jgarzik@pobox.com,
	netdev@vger.kernel.org, ipw2100-admin@linux.intel.com
Subject: [-mm patch] is_broadcast_ether_addr() is still required
Date: Fri, 8 Jul 2005 22:07:04 +0200	[thread overview]
Message-ID: <20050708200704.GH3671@stusta.de> (raw)

This patch by Bernhard Rosenkraenzer <bero@arklinux.org> is still 
required to fix the following compile error:

<--  snip  -->

...
  CC      drivers/net/wireless/ipw2200.o
...
drivers/net/wireless/ipw2200.c: In function `ipw_rx':
drivers/net/wireless/ipw2200.c:4937: warning: implicit declaration of function `is_broadcast_ether_addr'
...
  CC      net/ieee80211/ieee80211_tx.o
net/ieee80211/ieee80211_tx.c: In function `ieee80211_xmit':
net/ieee80211/ieee80211_tx.c:341: warning: implicit declaration of function `is_broadcast_ether_addr'
...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x422abc): In function `ipw_rx':
: undefined reference to `is_broadcast_ether_addr'
drivers/built-in.o(.text+0x4233f6): In function `ipw_rx':
: undefined reference to `is_broadcast_ether_addr'
drivers/built-in.o(.text+0x426b9f): In function 
`ipw_net_hard_start_xmit':
: undefined reference to `is_broadcast_ether_addr'
drivers/built-in.o(.text+0x426f9d): In function 
`ipw_net_hard_start_xmit':
: undefined reference to `is_broadcast_ether_addr'
net/built-in.o(.text+0x1e73c6): In function `ieee80211_xmit':
: undefined reference to `is_broadcast_ether_addr'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


is_broadcast_ether_addr() was removed but it's still used.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-rc1/include/net/ieee80211.h.ark	2005-07-01 17:46:22.000000000 +0200
+++ linux-2.6.13-rc1/include/net/ieee80211.h	2005-07-01 17:47:26.000000000 +0200
@@ -627,6 +627,11 @@
 #define MAC_FMT "%02x:%02x:%02x:%02x:%02x:%02x"
 #define MAC_ARG(x) ((u8*)(x))[0],((u8*)(x))[1],((u8*)(x))[2],((u8*)(x))[3],((u8*)(x))[4],((u8*)(x))[5]
 
+extern inline int is_broadcast_ether_addr(const u8 *addr)
+{
+	return ((addr[0] == 0xff) && (addr[1] == 0xff) && (addr[2] == 0xff) &&
+		(addr[3] == 0xff) && (addr[4] == 0xff) && (addr[5] == 0xff));
+}
 
 #define CFG_IEEE80211_RESERVE_FCS (1<<0)
 #define CFG_IEEE80211_COMPUTE_FCS (1<<1)



             reply	other threads:[~2005-07-08 20:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-08 20:07 Adrian Bunk [this message]
2005-07-08 20:45 ` [-mm patch] is_broadcast_ether_addr() is still required Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050708200704.GH3671@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=bero@arklinux.org \
    --cc=ipw2100-admin@linux.intel.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox