From: Olaf Hering <olh@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] implicit declaration of function `page_cache_release'
Date: Fri, 8 Jul 2005 22:35:14 +0200 [thread overview]
Message-ID: <20050708203514.GA31975@suse.de> (raw)
In-Reply-To: <20050708133127.302cbafe.akpm@osdl.org>
On Fri, Jul 08, Andrew Morton wrote:
> > +++ linux-2.6.13-rc2-olh/include/linux/pagemap.h
> > @@ -48,7 +48,7 @@ static inline void mapping_set_gfp_mask(
> >
> > #define page_cache_get(page) get_page(page)
> > #define page_cache_release(page) put_page(page)
> > -void release_pages(struct page **pages, int nr, int cold);
> > +extern void release_pages(struct page **pages, int nr, int cold);
>
> Why this change? I think that was just me saving disk space.
Its only used in mm/swap.c and in linux/swap.h.
However, swap.h is used in many places. If no extern works as well, just
drop that part.
next prev parent reply other threads:[~2005-07-08 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 15:03 [PATCH] implicit declaration of function `page_cache_release' Olaf Hering
2005-07-08 20:31 ` Andrew Morton
2005-07-08 20:35 ` Olaf Hering [this message]
2005-08-05 18:51 ` Benoit Boissinot
2005-08-05 19:00 ` Olaf Hering
2005-08-05 19:18 ` Benoit Boissinot
2005-08-06 13:55 ` David S. Miller
2005-08-06 15:01 ` Olaf Hering
2005-08-06 15:49 ` David S. Miller
2006-05-22 7:11 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050708203514.GA31975@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox