public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Documentation mismatch in Documentation/kbuild/kconfig-language.txt
@ 2005-07-04 14:59 Bodo Eggert
  2005-07-08 22:17 ` Adrian Bunk
  0 siblings, 1 reply; 6+ messages in thread
From: Bodo Eggert @ 2005-07-04 14:59 UTC (permalink / raw)
  To: linux-kernel

--- Documentation/kbuild/kconfig-language.txt ---
- input prompt: "prompt" <prompt> ["if" <expr>]
  Every menu entry can have at most one prompt, which is used to display
  to the user. Optionally dependencies only for this prompt can be added
  with "if".
---

This is misleading, since the "if" will not affect only the prompt, but 
also the config option. 

Therefore I can't use
config SGI_IOC4
    tristate
    prompt "SGI IOC4 Base IO support" if PROMPT_FOR_UNUSED_CORES
    depends on (IA64_GENERIC || IA64_SGI_SN2) && MMTIMER
    default n

to hide this option unless PROMPT_FOR_UNUSED_CORES is selected.

Since the "if" is useless, misleading and redundand with this behaviour, I 
suggest stripping it out.

-- 
Top 100 things you don't want the sysadmin to say:
43. The backup procedure works fine, but the restore is tricky!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Documentation mismatch in Documentation/kbuild/kconfig-language.txt
  2005-07-04 14:59 Documentation mismatch in Documentation/kbuild/kconfig-language.txt Bodo Eggert
@ 2005-07-08 22:17 ` Adrian Bunk
  2005-07-09  7:37   ` Bodo Eggert
  0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-07-08 22:17 UTC (permalink / raw)
  To: Bodo Eggert; +Cc: linux-kernel

On Mon, Jul 04, 2005 at 04:59:18PM +0200, Bodo Eggert wrote:
> --- Documentation/kbuild/kconfig-language.txt ---
> - input prompt: "prompt" <prompt> ["if" <expr>]
>   Every menu entry can have at most one prompt, which is used to display
>   to the user. Optionally dependencies only for this prompt can be added
>   with "if".
> ---
> 
> This is misleading, since the "if" will not affect only the prompt, but 
> also the config option. 
> 
> Therefore I can't use
> config SGI_IOC4
>     tristate
>     prompt "SGI IOC4 Base IO support" if PROMPT_FOR_UNUSED_CORES
>     depends on (IA64_GENERIC || IA64_SGI_SN2) && MMTIMER
>     default n
> 
> to hide this option unless PROMPT_FOR_UNUSED_CORES is selected.
> 
> Since the "if" is useless, misleading and redundand with this behaviour, I 
> suggest stripping it out.

"if" is valuable in "default y" cases.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Documentation mismatch in Documentation/kbuild/kconfig-language.txt
  2005-07-08 22:17 ` Adrian Bunk
@ 2005-07-09  7:37   ` Bodo Eggert
  2005-07-09  9:36     ` Adrian Bunk
  2005-07-09 13:24     ` Roman Zippel
  0 siblings, 2 replies; 6+ messages in thread
From: Bodo Eggert @ 2005-07-09  7:37 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Bodo Eggert, linux-kernel

On Sat, 9 Jul 2005, Adrian Bunk wrote:
> On Mon, Jul 04, 2005 at 04:59:18PM +0200, Bodo Eggert wrote:

...
> > Therefore I can't use
> > config SGI_IOC4
> >     tristate
> >     prompt "SGI IOC4 Base IO support" if PROMPT_FOR_UNUSED_CORES
> >     depends on (IA64_GENERIC || IA64_SGI_SN2) && MMTIMER
> >     default n
...
> > Since the "if" is useless, misleading and redundand with this behaviour, I 
> > suggest stripping it out.
> 
> "if" is valuable in "default y" cases.

It should be, but either it's really applied to the config instead of the 
prompt (in which can also be added to the depends on list) or the 
menuconfig '/' function has bogus output.

-- 
Top 100 things you don't want the sysadmin to say:
25. The only copy of Norton Utilities was on THAT disk???

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Documentation mismatch in Documentation/kbuild/kconfig-language.txt
  2005-07-09  7:37   ` Bodo Eggert
@ 2005-07-09  9:36     ` Adrian Bunk
  2005-07-09 21:14       ` Bodo Eggert
  2005-07-09 13:24     ` Roman Zippel
  1 sibling, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-07-09  9:36 UTC (permalink / raw)
  To: Bodo Eggert; +Cc: linux-kernel

On Sat, Jul 09, 2005 at 09:37:48AM +0200, Bodo Eggert wrote:
> On Sat, 9 Jul 2005, Adrian Bunk wrote:
> > On Mon, Jul 04, 2005 at 04:59:18PM +0200, Bodo Eggert wrote:
> 
> ...
> > > Therefore I can't use
> > > config SGI_IOC4
> > >     tristate
> > >     prompt "SGI IOC4 Base IO support" if PROMPT_FOR_UNUSED_CORES
> > >     depends on (IA64_GENERIC || IA64_SGI_SN2) && MMTIMER
> > >     default n
> ...
> > > Since the "if" is useless, misleading and redundand with this behaviour, I 
> > > suggest stripping it out.
> > 
> > "if" is valuable in "default y" cases.
> 
> It should be, but either it's really applied to the config instead of the 
> prompt (in which can also be added to the depends on list) or the 
> menuconfig '/' function has bogus output.

config FUTEX
        bool "Enable futex support" if EMBEDDED
        default y

This option is always "y" if EMBEDDED=n.
This option is uservisible if EMBEDDED=y.

I don't understand what's not working for you in this case.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Documentation mismatch in Documentation/kbuild/kconfig-language.txt
  2005-07-09  7:37   ` Bodo Eggert
  2005-07-09  9:36     ` Adrian Bunk
@ 2005-07-09 13:24     ` Roman Zippel
  1 sibling, 0 replies; 6+ messages in thread
From: Roman Zippel @ 2005-07-09 13:24 UTC (permalink / raw)
  To: Bodo Eggert; +Cc: Adrian Bunk, linux-kernel

Hi,

On Sat, 9 Jul 2005, Bodo Eggert wrote:

> On Sat, 9 Jul 2005, Adrian Bunk wrote:
> > On Mon, Jul 04, 2005 at 04:59:18PM +0200, Bodo Eggert wrote:
> 
> ...
> > > Therefore I can't use
> > > config SGI_IOC4
> > >     tristate
> > >     prompt "SGI IOC4 Base IO support" if PROMPT_FOR_UNUSED_CORES
> > >     depends on (IA64_GENERIC || IA64_SGI_SN2) && MMTIMER
> > >     default n
> ...
> > > Since the "if" is useless, misleading and redundand with this behaviour, I 
> > > suggest stripping it out.
> > 
> > "if" is valuable in "default y" cases.
> 
> It should be, but either it's really applied to the config instead of the 
> prompt (in which can also be added to the depends on list) or the 
> menuconfig '/' function has bogus output.

It's not bogus but simplified, look at the xconfig debug info for a more 
correct representation of the internal data.

bye, Roman

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Documentation mismatch in Documentation/kbuild/kconfig-language.txt
  2005-07-09  9:36     ` Adrian Bunk
@ 2005-07-09 21:14       ` Bodo Eggert
  0 siblings, 0 replies; 6+ messages in thread
From: Bodo Eggert @ 2005-07-09 21:14 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Bodo Eggert, linux-kernel

On Sat, 9 Jul 2005, Adrian Bunk wrote:
> On Sat, Jul 09, 2005 at 09:37:48AM +0200, Bodo Eggert wrote:

[menu dependencies "if" vs. "depends on"]

> > It should be, but either it's really applied to the config instead of the 
> > prompt (in which can also be added to the depends on list) or the 
> > menuconfig '/' function has bogus output.
> 
> config FUTEX
>         bool "Enable futex support" if EMBEDDED
>         default y
> 
> This option is always "y" if EMBEDDED=n.
> This option is uservisible if EMBEDDED=y.
> 
> I don't understand what's not working for you in this case.

I used make menuconfig for diagnosis, and it's output meges "depends on" 
with "if". Therefore I had to asume that the config logic does the same.
-- 
Top 100 things you don't want the sysadmin to say:
55. NO!  Not _that_ button!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-07-09 21:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-04 14:59 Documentation mismatch in Documentation/kbuild/kconfig-language.txt Bodo Eggert
2005-07-08 22:17 ` Adrian Bunk
2005-07-09  7:37   ` Bodo Eggert
2005-07-09  9:36     ` Adrian Bunk
2005-07-09 21:14       ` Bodo Eggert
2005-07-09 13:24     ` Roman Zippel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox