Re: [patch 2.6.12-rc3] modified firmware_class.c to add a new function request_firmware_nowait_nohotplug

Greg KH
2005-07-08T19:38:42Z

On Fri, Jul 08, 2005 at 07:16:38PM -0500, Abhay Salunke wrote:
> This is a patch which add a new function request_firmware_nowait_nohotplug
> in firmware_calss.c This function is exported and used by dell_rbu driver.
> It makes the file entries created by request_firmware to be agnostic to any
> hotplug or timeout events.
>
> Andrew ,
> Could you add this patch to the -mm tree. This patch was submitted about a
> week ago for review.

No, please do not.

> +/**
> + * request_firmware_nowait_nohotplug:
> + *
> + * Description:
> + * Similar to request_firmware_nowait except it does not use
> + * hotplug.
> + *
> + * @cont will be called asynchronously when the firmware request is over.
> + *
> + * @context will be passed over to @cont.
> + *
> + * @fw may be %NULL if firmware request fails.

Wrong kerneldoc format, please fix this.

Also, why not just add the hotplug flag to the firmware structure? That
way you don't have to add another function just to add another flag.
And you could probably get rid of the nowait version in the same way.

thanks,

greg k-h