[2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal (fwd)

[2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal (fwd)

[Adrian Bunk]

This patch I sent on 13 May 2005 is still not in Linus' tree, and now 
it's July.

What shall I do?
- resend this patch with the removal date set to August or
- send a patch to remove these symbols

cu
Adrian

<--  snip  -->


This patch schedules unused EXPORT_SYMBOL's for removal.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 Documentation/feature-removal-schedule.txt |   21 ++++++++++++++
 drivers/ieee1394/ieee1394_core.c           |   31 +++++++++++++++++++++
 2 files changed, 52 insertions(+)

--- linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt.old	2005-05-13 15:19:54.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt	2005-05-13 15:29:24.000000000 +0200
@@ -93,0 +94,21 @@
+
+---------------------------
+
+What:	remove the following ieee1394 EXPORT_SYMBOL's:
+	- hpsb_send_phy_config
+	- hpsb_send_packet_and_wait
+	- highlevel_add_host
+	- highlevel_remove_host
+	- nodemgr_for_each_host
+	- csr1212_create_csr
+	- csr1212_init_local_csr
+	- csr1212_new_immediate
+	- csr1212_associate_keyval
+	- csr1212_new_string_descriptor_leaf
+	- csr1212_destroy_csr
+	- csr1212_generate_csr_image
+	- csr1212_parse_csr
+When:	July 2005
+Files:	drivers/ieee1394/ieee1394_core.c
+Why:	No modular usage in the kernel.
+Who:	Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c.old	2005-05-13 15:19:34.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c	2005-05-13 15:28:17.000000000 +0200
@@ -1226,7 +1226,13 @@
 EXPORT_SYMBOL(hpsb_alloc_packet);
 EXPORT_SYMBOL(hpsb_free_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_phy_config);
+
 EXPORT_SYMBOL(hpsb_send_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_packet_and_wait);
+
 EXPORT_SYMBOL(hpsb_reset_bus);
 EXPORT_SYMBOL(hpsb_bus_reset);
@@ -1265,6 +1271,11 @@
 EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
 EXPORT_SYMBOL(hpsb_set_hostinfo);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_add_host);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_remove_host);
+
 EXPORT_SYMBOL(highlevel_host_reset);
 
@@ -1275,4 +1286,6 @@
 EXPORT_SYMBOL(hpsb_unregister_protocol);
 EXPORT_SYMBOL(ieee1394_bus_type);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(nodemgr_for_each_host);
 
@@ -1312,18 +1325,36 @@
 
 /** csr1212.c **/
+
+/* EXPORT_SYMBOLs scheduled for removal */
 EXPORT_SYMBOL(csr1212_create_csr);
 EXPORT_SYMBOL(csr1212_init_local_csr);
 EXPORT_SYMBOL(csr1212_new_immediate);
+
 EXPORT_SYMBOL(csr1212_new_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_associate_keyval);
+
 EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
+
 EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
 EXPORT_SYMBOL(csr1212_release_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_destroy_csr);
+
 EXPORT_SYMBOL(csr1212_read);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_generate_csr_image);
+
 EXPORT_SYMBOL(csr1212_parse_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_parse_csr);
+
 EXPORT_SYMBOL(_csr1212_read_keyval);
 EXPORT_SYMBOL(_csr1212_destroy_keyval);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

----- End forwarded message -----

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal (fwd)

[Jody McIntyre]

On Mon, Jul 04, 2005 at 01:24:05AM +0200, Adrian Bunk wrote:
> This patch I sent on 13 May 2005 is still not in Linus' tree, and now 
> it's July.

Sorry, I missed the original thread.  Feel free to CC me in future.

> What shall I do?
> - resend this patch with the removal date set to August or

That should be fine.  I'll watch for it this time.  August isn't much
time though; isn't the "standard" 6 months to a year?

Cheers,
Jody

> - send a patch to remove these symbols
> 
> cu
> Adrian
> 
> <--  snip  -->
> 
> 
> This patch schedules unused EXPORT_SYMBOL's for removal.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
>  Documentation/feature-removal-schedule.txt |   21 ++++++++++++++
>  drivers/ieee1394/ieee1394_core.c           |   31 +++++++++++++++++++++
>  2 files changed, 52 insertions(+)
> 
> --- linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt.old	2005-05-13 15:19:54.000000000 +0200
> +++ linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt	2005-05-13 15:29:24.000000000 +0200
> @@ -93,0 +94,21 @@
> +
> +---------------------------
> +
> +What:	remove the following ieee1394 EXPORT_SYMBOL's:
> +	- hpsb_send_phy_config
> +	- hpsb_send_packet_and_wait
> +	- highlevel_add_host
> +	- highlevel_remove_host
> +	- nodemgr_for_each_host
> +	- csr1212_create_csr
> +	- csr1212_init_local_csr
> +	- csr1212_new_immediate
> +	- csr1212_associate_keyval
> +	- csr1212_new_string_descriptor_leaf
> +	- csr1212_destroy_csr
> +	- csr1212_generate_csr_image
> +	- csr1212_parse_csr
> +When:	July 2005
> +Files:	drivers/ieee1394/ieee1394_core.c
> +Why:	No modular usage in the kernel.
> +Who:	Adrian Bunk <bunk@stusta.de>
> --- linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c.old	2005-05-13 15:19:34.000000000 +0200
> +++ linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c	2005-05-13 15:28:17.000000000 +0200
> @@ -1226,7 +1226,13 @@
>  EXPORT_SYMBOL(hpsb_alloc_packet);
>  EXPORT_SYMBOL(hpsb_free_packet);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(hpsb_send_phy_config);
> +
>  EXPORT_SYMBOL(hpsb_send_packet);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(hpsb_send_packet_and_wait);
> +
>  EXPORT_SYMBOL(hpsb_reset_bus);
>  EXPORT_SYMBOL(hpsb_bus_reset);
> @@ -1265,6 +1271,11 @@
>  EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
>  EXPORT_SYMBOL(hpsb_set_hostinfo);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(highlevel_add_host);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(highlevel_remove_host);
> +
>  EXPORT_SYMBOL(highlevel_host_reset);
>  
> @@ -1275,4 +1286,6 @@
>  EXPORT_SYMBOL(hpsb_unregister_protocol);
>  EXPORT_SYMBOL(ieee1394_bus_type);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(nodemgr_for_each_host);
>  
> @@ -1312,18 +1325,36 @@
>  
>  /** csr1212.c **/
> +
> +/* EXPORT_SYMBOLs scheduled for removal */
>  EXPORT_SYMBOL(csr1212_create_csr);
>  EXPORT_SYMBOL(csr1212_init_local_csr);
>  EXPORT_SYMBOL(csr1212_new_immediate);
> +
>  EXPORT_SYMBOL(csr1212_new_directory);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_associate_keyval);
> +
>  EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
> +
>  EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
>  EXPORT_SYMBOL(csr1212_release_keyval);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_destroy_csr);
> +
>  EXPORT_SYMBOL(csr1212_read);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_generate_csr_image);
> +
>  EXPORT_SYMBOL(csr1212_parse_keyval);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_parse_csr);
> +
>  EXPORT_SYMBOL(_csr1212_read_keyval);
>  EXPORT_SYMBOL(_csr1212_destroy_keyval);
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> ----- End forwarded message -----
> 
> cu
> Adrian
> 
> -- 
> 
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
> from IBM. Find simple to follow Roadmaps, straightforward articles,
> informative Webcasts and more! Get everything you need to get up to
> speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
> _______________________________________________
> mailing list linux1394-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux1394-devel

-- 

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal (fwd)

[Stefan Richter]

Jody McIntyre wrote:
> On Mon, Jul 04, 2005 at 01:24:05AM +0200, Adrian Bunk wrote:
>>What shall I do?
>>- resend this patch with the removal date set to August or
> 
> That should be fine.  I'll watch for it this time.  August isn't much
> time though; isn't the "standard" 6 months to a year?

August is fine; it's our sloppiness that the remove announcement did not 
go in earlier. People who run external projects that use such symbols 
might have had forewarning by the previous discussion rounds on 
linux1394-devel.

>>+What:	remove the following ieee1394 EXPORT_SYMBOL's:
>>+	- hpsb_send_phy_config
>>+	- hpsb_send_packet_and_wait
>>+	- highlevel_add_host
>>+	- highlevel_remove_host
>>+	- nodemgr_for_each_host
>>+	- csr1212_create_csr
>>+	- csr1212_init_local_csr
>>+	- csr1212_new_immediate
>>+	- csr1212_associate_keyval
>>+	- csr1212_new_string_descriptor_leaf
>>+	- csr1212_destroy_csr
>>+	- csr1212_generate_csr_image
>>+	- csr1212_parse_csr

Now that we are at it, the following EXPORT_SYMBOLs should be removed too...
	_csr1212_read_keyval
	_csr1212_destroy_keyval

>>+Files:	drivers/ieee1394/ieee1394_core.c
>>+Why:	No modular usage in the kernel.

...at the same place and for the same reason.
-- 
Stefan Richter
-=====-=-=-= -=== --===
http://arcgraph.de/sr/

[2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Adrian Bunk]

On Thu, Jul 07, 2005 at 09:30:21PM +0200, Stefan Richter wrote:
> Jody McIntyre wrote:
> >On Mon, Jul 04, 2005 at 01:24:05AM +0200, Adrian Bunk wrote:
> >>What shall I do?
> >>- resend this patch with the removal date set to August or
> >
> >That should be fine.  I'll watch for it this time.  August isn't much
> >time though; isn't the "standard" 6 months to a year?
> 
> August is fine; it's our sloppiness that the remove announcement did not 
> go in earlier. People who run external projects that use such symbols 
> might have had forewarning by the previous discussion rounds on 
> linux1394-devel.

Updated patch below.

> >>+What:	remove the following ieee1394 EXPORT_SYMBOL's:
> >>+	- hpsb_send_phy_config
> >>+	- hpsb_send_packet_and_wait
> >>+	- highlevel_add_host
> >>+	- highlevel_remove_host
> >>+	- nodemgr_for_each_host
> >>+	- csr1212_create_csr
> >>+	- csr1212_init_local_csr
> >>+	- csr1212_new_immediate
> >>+	- csr1212_associate_keyval
> >>+	- csr1212_new_string_descriptor_leaf
> >>+	- csr1212_destroy_csr
> >>+	- csr1212_generate_csr_image
> >>+	- csr1212_parse_csr
> 
> Now that we are at it, the following EXPORT_SYMBOLs should be removed too...
> 	_csr1212_read_keyval

used in sbp2.c

> 	_csr1212_destroy_keyval

used in raw1394.c

>...
> Stefan Richter

cu
Adrian


<--  snip  -->



This patch schedules unused EXPORT_SYMBOL's for removal.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 Documentation/feature-removal-schedule.txt |   21 ++++++++++++++
 drivers/ieee1394/ieee1394_core.c           |   31 +++++++++++++++++++++
 2 files changed, 52 insertions(+)

--- linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt.old	2005-05-13 15:19:54.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt	2005-05-13 15:29:24.000000000 +0200
@@ -93,0 +94,21 @@
+
+---------------------------
+
+What:	remove the following ieee1394 EXPORT_SYMBOL's:
+	- hpsb_send_phy_config
+	- hpsb_send_packet_and_wait
+	- highlevel_add_host
+	- highlevel_remove_host
+	- nodemgr_for_each_host
+	- csr1212_create_csr
+	- csr1212_init_local_csr
+	- csr1212_new_immediate
+	- csr1212_associate_keyval
+	- csr1212_new_string_descriptor_leaf
+	- csr1212_destroy_csr
+	- csr1212_generate_csr_image
+	- csr1212_parse_csr
+When:	August 2005
+Files:	drivers/ieee1394/ieee1394_core.c
+Why:	No modular usage in the kernel.
+Who:	Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c.old	2005-05-13 15:19:34.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c	2005-05-13 15:28:17.000000000 +0200
@@ -1226,7 +1226,13 @@
 EXPORT_SYMBOL(hpsb_alloc_packet);
 EXPORT_SYMBOL(hpsb_free_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_phy_config);
+
 EXPORT_SYMBOL(hpsb_send_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_packet_and_wait);
+
 EXPORT_SYMBOL(hpsb_reset_bus);
 EXPORT_SYMBOL(hpsb_bus_reset);
@@ -1265,6 +1271,11 @@
 EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
 EXPORT_SYMBOL(hpsb_set_hostinfo);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_add_host);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_remove_host);
+
 EXPORT_SYMBOL(highlevel_host_reset);
 
@@ -1275,4 +1286,6 @@
 EXPORT_SYMBOL(hpsb_unregister_protocol);
 EXPORT_SYMBOL(ieee1394_bus_type);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(nodemgr_for_each_host);
 
@@ -1312,18 +1325,36 @@
 
 /** csr1212.c **/
+
+/* EXPORT_SYMBOLs scheduled for removal */
 EXPORT_SYMBOL(csr1212_create_csr);
 EXPORT_SYMBOL(csr1212_init_local_csr);
 EXPORT_SYMBOL(csr1212_new_immediate);
+
 EXPORT_SYMBOL(csr1212_new_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_associate_keyval);
+
 EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
+
 EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
 EXPORT_SYMBOL(csr1212_release_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_destroy_csr);
+
 EXPORT_SYMBOL(csr1212_read);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_generate_csr_image);
+
 EXPORT_SYMBOL(csr1212_parse_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_parse_csr);
+
 EXPORT_SYMBOL(_csr1212_read_keyval);
 EXPORT_SYMBOL(_csr1212_destroy_keyval);

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Stefan Richter]

On  9 Jul, Adrian Bunk wrote:
> On Thu, Jul 07, 2005 at 09:30:21PM +0200, Stefan Richter wrote:
>> Now that we are at it, the following EXPORT_SYMBOLs should be removed too...
>> 	_csr1212_read_keyval
> used in sbp2.c
>> 	_csr1212_destroy_keyval
> used in raw1394.c

You are right.


<--  snip  -->



This patch schedules unused EXPORT_SYMBOL's for removal.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

---

 Documentation/feature-removal-schedule.txt |   21 ++++++++++++++
 drivers/ieee1394/ieee1394_core.c           |   31 +++++++++++++++++++++
 2 files changed, 52 insertions(+)

--- linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt.old	2005-05-13 15:19:54.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt	2005-05-13 15:29:24.000000000 +0200
@@ -93,0 +94,21 @@
+
+---------------------------
+
+What:	remove the following ieee1394 EXPORT_SYMBOL's:
+	- hpsb_send_phy_config
+	- hpsb_send_packet_and_wait
+	- highlevel_add_host
+	- highlevel_remove_host
+	- nodemgr_for_each_host
+	- csr1212_create_csr
+	- csr1212_init_local_csr
+	- csr1212_new_immediate
+	- csr1212_associate_keyval
+	- csr1212_new_string_descriptor_leaf
+	- csr1212_destroy_csr
+	- csr1212_generate_csr_image
+	- csr1212_parse_csr
+When:	August 2005
+Files:	drivers/ieee1394/ieee1394_core.c
+Why:	No modular usage in the kernel.
+Who:	Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c.old	2005-05-13 15:19:34.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c	2005-05-13 15:28:17.000000000 +0200
@@ -1226,7 +1226,13 @@
 EXPORT_SYMBOL(hpsb_alloc_packet);
 EXPORT_SYMBOL(hpsb_free_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_phy_config);
+
 EXPORT_SYMBOL(hpsb_send_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_packet_and_wait);
+
 EXPORT_SYMBOL(hpsb_reset_bus);
 EXPORT_SYMBOL(hpsb_bus_reset);
@@ -1265,6 +1271,11 @@
 EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
 EXPORT_SYMBOL(hpsb_set_hostinfo);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_add_host);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_remove_host);
+
 EXPORT_SYMBOL(highlevel_host_reset);
 
@@ -1275,4 +1286,6 @@
 EXPORT_SYMBOL(hpsb_unregister_protocol);
 EXPORT_SYMBOL(ieee1394_bus_type);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(nodemgr_for_each_host);
 
@@ -1312,18 +1325,36 @@
 
 /** csr1212.c **/
+
+/* EXPORT_SYMBOLs scheduled for removal */
 EXPORT_SYMBOL(csr1212_create_csr);
 EXPORT_SYMBOL(csr1212_init_local_csr);
 EXPORT_SYMBOL(csr1212_new_immediate);
+
 EXPORT_SYMBOL(csr1212_new_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_associate_keyval);
+
 EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
+
 EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
 EXPORT_SYMBOL(csr1212_release_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_destroy_csr);
+
 EXPORT_SYMBOL(csr1212_read);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_generate_csr_image);
+
 EXPORT_SYMBOL(csr1212_parse_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_parse_csr);
+
 EXPORT_SYMBOL(_csr1212_read_keyval);
 EXPORT_SYMBOL(_csr1212_destroy_keyval);

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Ben Collins]

Can we, instead of removing these, wrap then in a "Export full API" config
option? I've already got several reports from external projects that are
using most of these exported symbols, and I'd hate to make it harder on
them to use our drivers (for internal projects or otherwise).

On Sat, Jul 09, 2005 at 09:22:38AM +0200, Stefan Richter wrote:
> On  9 Jul, Adrian Bunk wrote:
> > On Thu, Jul 07, 2005 at 09:30:21PM +0200, Stefan Richter wrote:
> >> Now that we are at it, the following EXPORT_SYMBOLs should be removed too...
> >> 	_csr1212_read_keyval
> > used in sbp2.c
> >> 	_csr1212_destroy_keyval
> > used in raw1394.c
> 
> You are right.
> 
> 
> <--  snip  -->
> 
> 
> 
> This patch schedules unused EXPORT_SYMBOL's for removal.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> 
> ---
> 
>  Documentation/feature-removal-schedule.txt |   21 ++++++++++++++
>  drivers/ieee1394/ieee1394_core.c           |   31 +++++++++++++++++++++
>  2 files changed, 52 insertions(+)
> 
> --- linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt.old	2005-05-13 15:19:54.000000000 +0200
> +++ linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt	2005-05-13 15:29:24.000000000 +0200
> @@ -93,0 +94,21 @@
> +
> +---------------------------
> +
> +What:	remove the following ieee1394 EXPORT_SYMBOL's:
> +	- hpsb_send_phy_config
> +	- hpsb_send_packet_and_wait
> +	- highlevel_add_host
> +	- highlevel_remove_host
> +	- nodemgr_for_each_host
> +	- csr1212_create_csr
> +	- csr1212_init_local_csr
> +	- csr1212_new_immediate
> +	- csr1212_associate_keyval
> +	- csr1212_new_string_descriptor_leaf
> +	- csr1212_destroy_csr
> +	- csr1212_generate_csr_image
> +	- csr1212_parse_csr
> +When:	August 2005
> +Files:	drivers/ieee1394/ieee1394_core.c
> +Why:	No modular usage in the kernel.
> +Who:	Adrian Bunk <bunk@stusta.de>
> --- linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c.old	2005-05-13 15:19:34.000000000 +0200
> +++ linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c	2005-05-13 15:28:17.000000000 +0200
> @@ -1226,7 +1226,13 @@
>  EXPORT_SYMBOL(hpsb_alloc_packet);
>  EXPORT_SYMBOL(hpsb_free_packet);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(hpsb_send_phy_config);
> +
>  EXPORT_SYMBOL(hpsb_send_packet);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(hpsb_send_packet_and_wait);
> +
>  EXPORT_SYMBOL(hpsb_reset_bus);
>  EXPORT_SYMBOL(hpsb_bus_reset);
> @@ -1265,6 +1271,11 @@
>  EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
>  EXPORT_SYMBOL(hpsb_set_hostinfo);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(highlevel_add_host);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(highlevel_remove_host);
> +
>  EXPORT_SYMBOL(highlevel_host_reset);
>  
> @@ -1275,4 +1286,6 @@
>  EXPORT_SYMBOL(hpsb_unregister_protocol);
>  EXPORT_SYMBOL(ieee1394_bus_type);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(nodemgr_for_each_host);
>  
> @@ -1312,18 +1325,36 @@
>  
>  /** csr1212.c **/
> +
> +/* EXPORT_SYMBOLs scheduled for removal */
>  EXPORT_SYMBOL(csr1212_create_csr);
>  EXPORT_SYMBOL(csr1212_init_local_csr);
>  EXPORT_SYMBOL(csr1212_new_immediate);
> +
>  EXPORT_SYMBOL(csr1212_new_directory);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_associate_keyval);
> +
>  EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
> +
>  EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
>  EXPORT_SYMBOL(csr1212_release_keyval);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_destroy_csr);
> +
>  EXPORT_SYMBOL(csr1212_read);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_generate_csr_image);
> +
>  EXPORT_SYMBOL(csr1212_parse_keyval);
> +
> +/* EXPORT_SYMBOL scheduled for removal */
>  EXPORT_SYMBOL(csr1212_parse_csr);
> +
>  EXPORT_SYMBOL(_csr1212_read_keyval);
>  EXPORT_SYMBOL(_csr1212_destroy_keyval);
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by the 'Do More With Dual!' webinar happening
> July 14 at 8am PDT/11am EDT. We invite you to explore the latest in dual
> core and dual graphics technology at this free one hour event hosted by HP,
> AMD, and NVIDIA.  To register visit http://www.hp.com/go/dualwebinar
> _______________________________________________
> mailing list linux1394-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux1394-devel

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
SwissDisk  - http://www.swissdisk.com/

alternative [PATCH] 1/2) drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Stefan Richter]

Ben Collins wrote:
> Can we, instead of removing these, wrap then in a "Export full API" config
> option? I've already got several reports from external projects that are
> using most of these exported symbols, and I'd hate to make it harder on
> them to use our drivers (for internal projects or otherwise).

OK, why not. Here is an alternative patch, split in two parts. The first
part is independent of the second, although the 2nd motivates the 1st.
2nd part follows in a separate posting.

- - - - - - - - - - - - 8< - - - - - - - - - - - -

IEEE 1394 subsystem: Wrap symbols that are neither used by the 1394 drivers in
the mainline kernel (a.k.a. Linux1394) nor by dfg1394 (a.k.a the video-2-1394
project) into a new configuration option. Switch this option on by default.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>


diff -ru linux-2.6.13-rc2.old/drivers/ieee1394/Kconfig linux-2.6.13-rc2/drivers/ieee1394/Kconfig
--- linux-2.6.13-rc2.old/drivers/ieee1394/Kconfig	2005-07-06 05:46:33.000000000 +0200
+++ linux-2.6.13-rc2/drivers/ieee1394/Kconfig	2005-07-09 12:01:32.000000000 +0200
@@ -66,6 +66,18 @@
 	  with MacOSX and WinXP IP-over-1394), enable this option and the
 	  eth1394 option below.
 
+config IEEE1394_EXPORT_FULL_API
+	bool "Export all symbols of ieee1394's API"
+	depends on IEEE1394
+	default y
+	help
+	  Export all symbols of ieee1394's driver programming interface, even
+	  those that are not currently used by the standard IEEE 1394 drivers.
+
+	  This option does not affect the interface to userspace applications.
+	  Say Y here if you want to compile externally developed drivers that
+	  make extended use of ieee1394's API. It is otherwise safe to say N.
+
 comment "Device Drivers"
 	depends on IEEE1394
 
diff -ru linux-2.6.13-rc2.old/drivers/ieee1394/ieee1394_core.c linux-2.6.13-rc2/drivers/ieee1394/ieee1394_core.c
--- linux-2.6.13-rc2.old/drivers/ieee1394/ieee1394_core.c	2005-07-06 05:46:33.000000000 +0200
+++ linux-2.6.13-rc2/drivers/ieee1394/ieee1394_core.c	2005-07-09 11:53:25.000000000 +0200
@@ -1223,9 +1223,7 @@
 EXPORT_SYMBOL(hpsb_set_packet_complete_task);
 EXPORT_SYMBOL(hpsb_alloc_packet);
 EXPORT_SYMBOL(hpsb_free_packet);
-EXPORT_SYMBOL(hpsb_send_phy_config);
 EXPORT_SYMBOL(hpsb_send_packet);
-EXPORT_SYMBOL(hpsb_send_packet_and_wait);
 EXPORT_SYMBOL(hpsb_reset_bus);
 EXPORT_SYMBOL(hpsb_bus_reset);
 EXPORT_SYMBOL(hpsb_selfid_received);
@@ -1233,6 +1231,10 @@
 EXPORT_SYMBOL(hpsb_packet_sent);
 EXPORT_SYMBOL(hpsb_packet_received);
 EXPORT_SYMBOL_GPL(hpsb_disable_irm);
+#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
+EXPORT_SYMBOL(hpsb_send_phy_config);
+EXPORT_SYMBOL(hpsb_send_packet_and_wait);
+#endif
 
 /** ieee1394_transactions.c **/
 EXPORT_SYMBOL(hpsb_get_tlabel);
@@ -1262,9 +1264,11 @@
 EXPORT_SYMBOL(hpsb_set_hostinfo_key);
 EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
 EXPORT_SYMBOL(hpsb_set_hostinfo);
+EXPORT_SYMBOL(highlevel_host_reset);
+#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
 EXPORT_SYMBOL(highlevel_add_host);
 EXPORT_SYMBOL(highlevel_remove_host);
-EXPORT_SYMBOL(highlevel_host_reset);
+#endif
 
 /** nodemgr.c **/
 EXPORT_SYMBOL(hpsb_node_fill_packet);
@@ -1272,7 +1276,9 @@
 EXPORT_SYMBOL(hpsb_register_protocol);
 EXPORT_SYMBOL(hpsb_unregister_protocol);
 EXPORT_SYMBOL(ieee1394_bus_type);
+#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
 EXPORT_SYMBOL(nodemgr_for_each_host);
+#endif
 
 /** csr.c **/
 EXPORT_SYMBOL(hpsb_update_config_rom);
@@ -1309,19 +1315,21 @@
 EXPORT_SYMBOL(hpsb_iso_recv_flush);
 
 /** csr1212.c **/
-EXPORT_SYMBOL(csr1212_create_csr);
-EXPORT_SYMBOL(csr1212_init_local_csr);
-EXPORT_SYMBOL(csr1212_new_immediate);
 EXPORT_SYMBOL(csr1212_new_directory);
-EXPORT_SYMBOL(csr1212_associate_keyval);
 EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
-EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
 EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
 EXPORT_SYMBOL(csr1212_release_keyval);
-EXPORT_SYMBOL(csr1212_destroy_csr);
 EXPORT_SYMBOL(csr1212_read);
-EXPORT_SYMBOL(csr1212_generate_csr_image);
 EXPORT_SYMBOL(csr1212_parse_keyval);
-EXPORT_SYMBOL(csr1212_parse_csr);
 EXPORT_SYMBOL(_csr1212_read_keyval);
 EXPORT_SYMBOL(_csr1212_destroy_keyval);
+#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
+EXPORT_SYMBOL(csr1212_create_csr);
+EXPORT_SYMBOL(csr1212_init_local_csr);
+EXPORT_SYMBOL(csr1212_new_immediate);
+EXPORT_SYMBOL(csr1212_associate_keyval);
+EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
+EXPORT_SYMBOL(csr1212_destroy_csr);
+EXPORT_SYMBOL(csr1212_generate_csr_image);
+EXPORT_SYMBOL(csr1212_parse_csr);
+#endif

Re: alternative [PATCH] 1/2) drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Ben Collins]

Now that I can live with. If everyone else is ok with it, I'll apply it to
our tree for when I sync to Linus.

On Sat, Jul 09, 2005 at 12:32:33PM +0200, Stefan Richter wrote:
> Ben Collins wrote:
> > Can we, instead of removing these, wrap then in a "Export full API" config
> > option? I've already got several reports from external projects that are
> > using most of these exported symbols, and I'd hate to make it harder on
> > them to use our drivers (for internal projects or otherwise).
> 
> OK, why not. Here is an alternative patch, split in two parts. The first
> part is independent of the second, although the 2nd motivates the 1st.
> 2nd part follows in a separate posting.
> 
> - - - - - - - - - - - - 8< - - - - - - - - - - - -
> 
> IEEE 1394 subsystem: Wrap symbols that are neither used by the 1394 drivers in
> the mainline kernel (a.k.a. Linux1394) nor by dfg1394 (a.k.a the video-2-1394
> project) into a new configuration option. Switch this option on by default.
> 
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> 
> 
> diff -ru linux-2.6.13-rc2.old/drivers/ieee1394/Kconfig linux-2.6.13-rc2/drivers/ieee1394/Kconfig
> --- linux-2.6.13-rc2.old/drivers/ieee1394/Kconfig	2005-07-06 05:46:33.000000000 +0200
> +++ linux-2.6.13-rc2/drivers/ieee1394/Kconfig	2005-07-09 12:01:32.000000000 +0200
> @@ -66,6 +66,18 @@
>  	  with MacOSX and WinXP IP-over-1394), enable this option and the
>  	  eth1394 option below.
>  
> +config IEEE1394_EXPORT_FULL_API
> +	bool "Export all symbols of ieee1394's API"
> +	depends on IEEE1394
> +	default y
> +	help
> +	  Export all symbols of ieee1394's driver programming interface, even
> +	  those that are not currently used by the standard IEEE 1394 drivers.
> +
> +	  This option does not affect the interface to userspace applications.
> +	  Say Y here if you want to compile externally developed drivers that
> +	  make extended use of ieee1394's API. It is otherwise safe to say N.
> +
>  comment "Device Drivers"
>  	depends on IEEE1394
>  
> diff -ru linux-2.6.13-rc2.old/drivers/ieee1394/ieee1394_core.c linux-2.6.13-rc2/drivers/ieee1394/ieee1394_core.c
> --- linux-2.6.13-rc2.old/drivers/ieee1394/ieee1394_core.c	2005-07-06 05:46:33.000000000 +0200
> +++ linux-2.6.13-rc2/drivers/ieee1394/ieee1394_core.c	2005-07-09 11:53:25.000000000 +0200
> @@ -1223,9 +1223,7 @@
>  EXPORT_SYMBOL(hpsb_set_packet_complete_task);
>  EXPORT_SYMBOL(hpsb_alloc_packet);
>  EXPORT_SYMBOL(hpsb_free_packet);
> -EXPORT_SYMBOL(hpsb_send_phy_config);
>  EXPORT_SYMBOL(hpsb_send_packet);
> -EXPORT_SYMBOL(hpsb_send_packet_and_wait);
>  EXPORT_SYMBOL(hpsb_reset_bus);
>  EXPORT_SYMBOL(hpsb_bus_reset);
>  EXPORT_SYMBOL(hpsb_selfid_received);
> @@ -1233,6 +1231,10 @@
>  EXPORT_SYMBOL(hpsb_packet_sent);
>  EXPORT_SYMBOL(hpsb_packet_received);
>  EXPORT_SYMBOL_GPL(hpsb_disable_irm);
> +#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
> +EXPORT_SYMBOL(hpsb_send_phy_config);
> +EXPORT_SYMBOL(hpsb_send_packet_and_wait);
> +#endif
>  
>  /** ieee1394_transactions.c **/
>  EXPORT_SYMBOL(hpsb_get_tlabel);
> @@ -1262,9 +1264,11 @@
>  EXPORT_SYMBOL(hpsb_set_hostinfo_key);
>  EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
>  EXPORT_SYMBOL(hpsb_set_hostinfo);
> +EXPORT_SYMBOL(highlevel_host_reset);
> +#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
>  EXPORT_SYMBOL(highlevel_add_host);
>  EXPORT_SYMBOL(highlevel_remove_host);
> -EXPORT_SYMBOL(highlevel_host_reset);
> +#endif
>  
>  /** nodemgr.c **/
>  EXPORT_SYMBOL(hpsb_node_fill_packet);
> @@ -1272,7 +1276,9 @@
>  EXPORT_SYMBOL(hpsb_register_protocol);
>  EXPORT_SYMBOL(hpsb_unregister_protocol);
>  EXPORT_SYMBOL(ieee1394_bus_type);
> +#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
>  EXPORT_SYMBOL(nodemgr_for_each_host);
> +#endif
>  
>  /** csr.c **/
>  EXPORT_SYMBOL(hpsb_update_config_rom);
> @@ -1309,19 +1315,21 @@
>  EXPORT_SYMBOL(hpsb_iso_recv_flush);
>  
>  /** csr1212.c **/
> -EXPORT_SYMBOL(csr1212_create_csr);
> -EXPORT_SYMBOL(csr1212_init_local_csr);
> -EXPORT_SYMBOL(csr1212_new_immediate);
>  EXPORT_SYMBOL(csr1212_new_directory);
> -EXPORT_SYMBOL(csr1212_associate_keyval);
>  EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
> -EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
>  EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
>  EXPORT_SYMBOL(csr1212_release_keyval);
> -EXPORT_SYMBOL(csr1212_destroy_csr);
>  EXPORT_SYMBOL(csr1212_read);
> -EXPORT_SYMBOL(csr1212_generate_csr_image);
>  EXPORT_SYMBOL(csr1212_parse_keyval);
> -EXPORT_SYMBOL(csr1212_parse_csr);
>  EXPORT_SYMBOL(_csr1212_read_keyval);
>  EXPORT_SYMBOL(_csr1212_destroy_keyval);
> +#ifdef CONFIG_IEEE1394_EXPORT_FULL_API
> +EXPORT_SYMBOL(csr1212_create_csr);
> +EXPORT_SYMBOL(csr1212_init_local_csr);
> +EXPORT_SYMBOL(csr1212_new_immediate);
> +EXPORT_SYMBOL(csr1212_associate_keyval);
> +EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
> +EXPORT_SYMBOL(csr1212_destroy_csr);
> +EXPORT_SYMBOL(csr1212_generate_csr_image);
> +EXPORT_SYMBOL(csr1212_parse_csr);
> +#endif
> 

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
SwissDisk  - http://www.swissdisk.com/

Re: alternative [PATCH] 1/2) drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Ben Collins]

Applied, but I set the default to "N". No reason to prolong doing it,
since it doesn't break anything in the kernel or in our tree. It's an easy
pointer to the option for anyone inquiring about the change.

On Sat, Jul 09, 2005 at 12:32:33PM +0200, Stefan Richter wrote:
> Ben Collins wrote:
> > Can we, instead of removing these, wrap then in a "Export full API" config
> > option? I've already got several reports from external projects that are
> > using most of these exported symbols, and I'd hate to make it harder on
> > them to use our drivers (for internal projects or otherwise).
> 
> OK, why not. Here is an alternative patch, split in two parts. The first
> part is independent of the second, although the 2nd motivates the 1st.
> 2nd part follows in a separate posting.

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
SwissDisk  - http://www.swissdisk.com/

alternative [PATCH] 2/2) drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Stefan Richter]

IEEE 1394 subsystem: Unused EXPORT_SYMBOLs will be disabled as of August.
Based on a proposal by Adrian Bunk <bunk@stusta.de>.
May affect external FireWire driver projects.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>


diff -ru linux-2.6.13-rc2.old/Documentation/feature-removal-schedule.txt linux-2.6.13-rc2/Documentation/feature-removal-schedule.txt
--- linux-2.6.13-rc2.old/Documentation/feature-removal-schedule.txt	2005-07-06 05:46:33.000000000 +0200
+++ linux-2.6.13-rc2/Documentation/feature-removal-schedule.txt	2005-07-09 11:32:43.000000000 +0200
@@ -102,6 +102,22 @@
 
 ---------------------------
 
+What:	Make IEEE1394_EXPORT_FULL_API=n the default. Will disable the
+	following EXPORT_SYMBOLs in drivers/ieee1394/ieee1394_core.c:
+	hpsb_send_phy_config,     hpsb_send_packet_and_wait,
+	highlevel_add_host,       highlevel_remove_host,
+	nodemgr_for_each_host,    csr1212_create_csr,
+	csr1212_init_local_csr,   csr1212_new_immediate,
+	csr1212_associate_keyval, csr1212_new_string_descriptor_leaf,
+	csr1212_destroy_csr,      csr1212_generate_csr_image,
+	csr1212_parse_csr
+When:	August 2005
+Files:	drivers/ieee1394/Kconfig
+Why:	No modular usage in the kernel.
+Who:	Stefan Richter <stefanr@s5r6.in-berlin.de>
+
+---------------------------
+
 What:	register_serial/unregister_serial
 When:	December 2005
 Why:	This interface does not allow serial ports to be registered against

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Adrian Bunk]

On Sat, Jul 09, 2005 at 03:50:35AM -0400, Ben Collins wrote:

> Can we, instead of removing these, wrap then in a "Export full API" config
> option? I've already got several reports from external projects that are

This will end in all distributions having this option enabled resulting 
in no change compared to todays status quo.

> using most of these exported symbols, and I'd hate to make it harder on
> them to use our drivers (for internal projects or otherwise).

What are these external projects?

Is they are internal projects, re-adding the EXPORT_SYMBOL's should be 
trivial for them.

If they aren't only internal internal project, why can't they simply be 
merged (making all discussions about removal of the EXPORT_SYMBOL's they 
use obsolete)?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Stefan Richter]

Adrian Bunk wrote:
> On Sat, Jul 09, 2005 at 03:50:35AM -0400, Ben Collins wrote:
>> Can we, instead of removing these, wrap then in a "Export full API" config
>> option? I've already got several reports from external projects that are
> 
> This will end in all distributions having this option enabled resulting 
> in no change compared to todays status quo.

I disagree. Distributors, especially those oriented towards private/
SOHO/ big commercial customers, don't need to care much for classroom
projects or the hacker next door. Distributors will not enable this
option once it defaults to off in mainline. This config option is
ultimately *no* solution for commercial support of external drivers,
regardless whether they are free software or unfree. The patch does not
attempt to establish a warranted managed API.

>> using most of these exported symbols, and I'd hate to make it harder on
>> them to use our drivers (for internal projects or otherwise).
> 
> What are these external projects?

There are countless FireWire related projects, especially in academia.
For example, FireWire seems to be a hit in robotics. We at
linux1394-devel may not even hear about what they are doing in
particular but we do get feedback, bugfixes, and improvements from them.
For them, Linux' IEEE 1394 stack may be only one choice out of several,
including stacks in the big desktop operating systems or in various
embedded OSs. So in my personal opinion, it is in best interest for
Linux' 1394 stack if we can keep these people motivated to stick with
Linux.

> Is they are internal projects, re-adding the EXPORT_SYMBOL's should be 
> trivial for them.

We make it even more trivial by providing a compile option for that. The
cost is minimal.
-- 
Stefan Richter
-=====-=-=-= -=== -=--=
http://arcgraph.de/sr/

Re: [2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Ben Collins]

On Sat, Jul 09, 2005 at 08:55:57PM +0200, Adrian Bunk wrote:
> On Sat, Jul 09, 2005 at 03:50:35AM -0400, Ben Collins wrote:
> 
> > Can we, instead of removing these, wrap then in a "Export full API" config
> > option? I've already got several reports from external projects that are
> 
> This will end in all distributions having this option enabled resulting 
> in no change compared to todays status quo.

Yeah, I've heard this over and over, but as someone who works with
distributing Linux, I can say it is utterly incorrect. Distributors are
looking to support as little as possible and make things as tight and
stable as possible. THe API is only there for people doing development
work of some sort, and those people are going to be building kernels from
scratch anyway. That's the people that will enable this option.

And if it's as you suggest, that there is so much demand on the
distributions by users to enable this option, then by all means that
should show that it needs to be there anyway, don't you think? Not only
that, the distributions could just as easily add patches to put them back,
in order to support it, so taking it out completely doesn't help anything.


> > using most of these exported symbols, and I'd hate to make it harder on
> > them to use our drivers (for internal projects or otherwise).
> 
> What are these external projects?
> 
> Is they are internal projects, re-adding the EXPORT_SYMBOL's should be 
> trivial for them.
> 
> If they aren't only internal internal project, why can't they simply be 
> merged (making all discussions about removal of the EXPORT_SYMBOL's they 
> use obsolete)?

These projects all fall in a lot of categories, from hobbyist, to
acedemics, to companies doing embedded systems (I've gotten feedback from
someone using linux1394 in next generation US fighter planes, and they
have some custom modules).

Allowing them to do as little changing to the kernel as possible makes
their life easier, and ensures that changes we get back are cleaner and
more useful. Plus for two of those three examples, they may be
distributing their work to classmates or other hobbyists. THis might be in
the way of a single driver file that can be compiled with a stock kernel,
and no one wants to say "oh, and you need to patch the ieee1394 drivers
before you can use my driver".

-- 
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
Subversion - http://subversion.tigris.org/
SwissDisk  - http://www.swissdisk.com/

[2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Adrian Bunk]

This patch removes unneeded EXPORT_SYMBOL's.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/ieee1394/ieee1394_core.c |   16 ----------------
 1 files changed, 16 deletions(-)

--- linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_core.c.old	2005-04-17 20:49:31.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_core.c	2005-04-17 20:57:34.000000000 +0200
@@ -1225,9 +1225,7 @@
 EXPORT_SYMBOL(hpsb_set_packet_complete_task);
 EXPORT_SYMBOL(hpsb_alloc_packet);
 EXPORT_SYMBOL(hpsb_free_packet);
-EXPORT_SYMBOL(hpsb_send_phy_config);
 EXPORT_SYMBOL(hpsb_send_packet);
-EXPORT_SYMBOL(hpsb_send_packet_and_wait);
 EXPORT_SYMBOL(hpsb_reset_bus);
 EXPORT_SYMBOL(hpsb_bus_reset);
 EXPORT_SYMBOL(hpsb_selfid_received);
@@ -1246,9 +1244,6 @@
 EXPORT_SYMBOL(hpsb_make_lock64packet);
 EXPORT_SYMBOL(hpsb_make_phypacket);
 EXPORT_SYMBOL(hpsb_make_isopacket);
-EXPORT_SYMBOL(hpsb_read);
-EXPORT_SYMBOL(hpsb_write);
-EXPORT_SYMBOL(hpsb_lock);
 EXPORT_SYMBOL(hpsb_packet_success);
 
 /** highlevel.c **/
@@ -1265,8 +1260,6 @@
 EXPORT_SYMBOL(hpsb_set_hostinfo_key);
 EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
 EXPORT_SYMBOL(hpsb_set_hostinfo);
-EXPORT_SYMBOL(highlevel_add_host);
-EXPORT_SYMBOL(highlevel_remove_host);
 EXPORT_SYMBOL(highlevel_host_reset);
 
 /** nodemgr.c **/
@@ -1275,7 +1268,6 @@
 EXPORT_SYMBOL(hpsb_register_protocol);
 EXPORT_SYMBOL(hpsb_unregister_protocol);
 EXPORT_SYMBOL(ieee1394_bus_type);
-EXPORT_SYMBOL(nodemgr_for_each_host);
 
 /** csr.c **/
 EXPORT_SYMBOL(hpsb_update_config_rom);
@@ -1312,19 +1304,11 @@
 EXPORT_SYMBOL(hpsb_iso_recv_flush);
 
 /** csr1212.c **/
-EXPORT_SYMBOL(csr1212_create_csr);
-EXPORT_SYMBOL(csr1212_init_local_csr);
-EXPORT_SYMBOL(csr1212_new_immediate);
 EXPORT_SYMBOL(csr1212_new_directory);
-EXPORT_SYMBOL(csr1212_associate_keyval);
 EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
-EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
 EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
 EXPORT_SYMBOL(csr1212_release_keyval);
-EXPORT_SYMBOL(csr1212_destroy_csr);
 EXPORT_SYMBOL(csr1212_read);
-EXPORT_SYMBOL(csr1212_generate_csr_image);
 EXPORT_SYMBOL(csr1212_parse_keyval);
-EXPORT_SYMBOL(csr1212_parse_csr);
 EXPORT_SYMBOL(_csr1212_read_keyval);
 EXPORT_SYMBOL(_csr1212_destroy_keyval);

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Jody McIntyre]

On Sun, Apr 17, 2005 at 09:57:07PM +0200, Adrian Bunk wrote:
> This patch removes unneeded EXPORT_SYMBOL's.

Didn't you already send something like this (with fewer removals, mind
you) in December?

http://marc.theaimsgroup.com/?l=linux1394-devel&m=110350765817261&w=2

Given the objections to your December patch, why should we accept this
one now?

Jody

> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
>  drivers/ieee1394/ieee1394_core.c |   16 ----------------
>  1 files changed, 16 deletions(-)
> 
> --- linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_core.c.old	2005-04-17 20:49:31.000000000 +0200
> +++ linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_core.c	2005-04-17 20:57:34.000000000 +0200
> @@ -1225,9 +1225,7 @@
>  EXPORT_SYMBOL(hpsb_set_packet_complete_task);
>  EXPORT_SYMBOL(hpsb_alloc_packet);
>  EXPORT_SYMBOL(hpsb_free_packet);
> -EXPORT_SYMBOL(hpsb_send_phy_config);
>  EXPORT_SYMBOL(hpsb_send_packet);
> -EXPORT_SYMBOL(hpsb_send_packet_and_wait);
>  EXPORT_SYMBOL(hpsb_reset_bus);
>  EXPORT_SYMBOL(hpsb_bus_reset);
>  EXPORT_SYMBOL(hpsb_selfid_received);
> @@ -1246,9 +1244,6 @@
>  EXPORT_SYMBOL(hpsb_make_lock64packet);
>  EXPORT_SYMBOL(hpsb_make_phypacket);
>  EXPORT_SYMBOL(hpsb_make_isopacket);
> -EXPORT_SYMBOL(hpsb_read);
> -EXPORT_SYMBOL(hpsb_write);
> -EXPORT_SYMBOL(hpsb_lock);
>  EXPORT_SYMBOL(hpsb_packet_success);
>  
>  /** highlevel.c **/
> @@ -1265,8 +1260,6 @@
>  EXPORT_SYMBOL(hpsb_set_hostinfo_key);
>  EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
>  EXPORT_SYMBOL(hpsb_set_hostinfo);
> -EXPORT_SYMBOL(highlevel_add_host);
> -EXPORT_SYMBOL(highlevel_remove_host);
>  EXPORT_SYMBOL(highlevel_host_reset);
>  
>  /** nodemgr.c **/
> @@ -1275,7 +1268,6 @@
>  EXPORT_SYMBOL(hpsb_register_protocol);
>  EXPORT_SYMBOL(hpsb_unregister_protocol);
>  EXPORT_SYMBOL(ieee1394_bus_type);
> -EXPORT_SYMBOL(nodemgr_for_each_host);
>  
>  /** csr.c **/
>  EXPORT_SYMBOL(hpsb_update_config_rom);
> @@ -1312,19 +1304,11 @@
>  EXPORT_SYMBOL(hpsb_iso_recv_flush);
>  
>  /** csr1212.c **/
> -EXPORT_SYMBOL(csr1212_create_csr);
> -EXPORT_SYMBOL(csr1212_init_local_csr);
> -EXPORT_SYMBOL(csr1212_new_immediate);
>  EXPORT_SYMBOL(csr1212_new_directory);
> -EXPORT_SYMBOL(csr1212_associate_keyval);
>  EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
> -EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
>  EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
>  EXPORT_SYMBOL(csr1212_release_keyval);
> -EXPORT_SYMBOL(csr1212_destroy_csr);
>  EXPORT_SYMBOL(csr1212_read);
> -EXPORT_SYMBOL(csr1212_generate_csr_image);
>  EXPORT_SYMBOL(csr1212_parse_keyval);
> -EXPORT_SYMBOL(csr1212_parse_csr);
>  EXPORT_SYMBOL(_csr1212_read_keyval);
>  EXPORT_SYMBOL(_csr1212_destroy_keyval);
> 
> 
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> mailing list linux1394-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux1394-devel

-- 

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Arjan van de Ven]

On Tue, 2005-04-19 at 15:13 -0400, Jody McIntyre wrote:
> On Sun, Apr 17, 2005 at 09:57:07PM +0200, Adrian Bunk wrote:
> > This patch removes unneeded EXPORT_SYMBOL's.
> 
> Didn't you already send something like this (with fewer removals, mind
> you) in December?
> 
> http://marc.theaimsgroup.com/?l=linux1394-devel&m=110350765817261&w=2
> 
> Given the objections to your December patch, why should we accept this
> one now?

since there still isn't a user ??

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Stefan Richter]

Arjan van de Ven wrote:
> On Tue, 2005-04-19 at 15:13 -0400, Jody McIntyre wrote:
>> On Sun, Apr 17, 2005 at 09:57:07PM +0200, Adrian Bunk wrote:
>> > This patch removes unneeded EXPORT_SYMBOL's.
...
>> Given the objections to your December patch, why should we accept this
>> one now?
> 
> since there still isn't a user ??

There are users (though not in "the" kernel at the moment), have been
users, will be users.

Note: There is no architectural problem or something like that which
would be a reason to change the API.
-- 
Stefan Richter
-=====-=-=-= --== -===-
http://arcgraph.de/sr/

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Arjan van de Ven]

On Wed, 2005-04-20 at 00:00 +0200, Stefan Richter wrote:
> Arjan van de Ven wrote:
> > On Tue, 2005-04-19 at 15:13 -0400, Jody McIntyre wrote:
> >> On Sun, Apr 17, 2005 at 09:57:07PM +0200, Adrian Bunk wrote:
> >> > This patch removes unneeded EXPORT_SYMBOL's.
> ...
> >> Given the objections to your December patch, why should we accept this
> >> one now?
> > 
> > since there still isn't a user ??
> 
> There are users (though not in "the" kernel at the moment)

nor for the last 5 months... how long will it be ?

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Stefan Richter]

Arjan van de Ven wrote:
> On Wed, 2005-04-20 at 00:00 +0200, Stefan Richter wrote:
>>There are users (though not in "the" kernel at the moment)
> nor for the last 5 months... how long will it be ?

Have there been problems with the API during the past 5 months, except 
that several kernel trees are using some parts of the API? (We are 
actually speaking about two APIs of the ieee1394 framework.)

Which problems are solved by this patch? Do they outweigh the problems 
it creates? The latter have been discussed. Dismissing them as Other 
People's Problems does not nullify them.

Where is the agreed-upon, published plan for removal of features in 
ieee1394?
-- 
Stefan Richter
-=====-=-=-= -=-- =-=--
http://arcgraph.de/sr/

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Dan Dennedy]

On Wed, 2005-04-20 at 18:31 +0200, Stefan Richter wrote:
> Arjan van de Ven wrote:
> > On Wed, 2005-04-20 at 00:00 +0200, Stefan Richter wrote:
> >>There are users (though not in "the" kernel at the moment)
> > nor for the last 5 months... how long will it be ?
> 
> Have there been problems with the API during the past 5 months, except 
> that several kernel trees are using some parts of the API? (We are 
> actually speaking about two APIs of the ieee1394 framework.)
> 
> Which problems are solved by this patch? Do they outweigh the problems 
> it creates? The latter have been discussed. Dismissing them as Other 
> People's Problems does not nullify them.
> 
> Where is the agreed-upon, published plan for removal of features in 
> ieee1394?

Of course, there is none. In an unofficial capacity, there is just the
opinion and votes of the subsystem maintainers, extended team (e.g.,
Stefan and me), and kernel maintainers (Linus, Andrew, and Marcello).
The users are represented by the subsystem maintainers and extended
team. So, Arjan's opinion does not matter except to offer some voice of
reason.

I think I was first to raise objection upon the initial submission some
months back, and then I just observed the dialog. There are technical
merits for removal of the external symbols that I accept. I also accept
that we have no way of maintaining any sort of stable subsystem for
external projects we are not aware of or who are not communicating with
us about their requirements (it goes beyond just a stable interface).

Based upon my experience of several years on this project there is only
one external kernel module project we need to consider because that
developer has been involved and voiced requirements. That is Arne
Caspari's (The Imaging Source) DFG/1394 driver. 

I vote to remove external symbols not used by the Linux1394.org modules
or the module at http://sourceforge.net/projects/video-2-1394/
Of course, I may be voted down, but I ask the others to be realistic
about what we are arguing for (i.e. just being defensive?) and consider
the fact that there are valid reasons for their removal.

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Stefan Richter]

Dan Dennedy wrote on 2005-04-20:
> There are technical
> merits for removal of the external symbols that I accept. I also accept
> that we have no way of maintaining any sort of stable subsystem for
> external projects we are not aware of or who are not communicating with
> us about their requirements (it goes beyond just a stable interface).
...
> I vote to remove external symbols not used by the Linux1394.org modules
> or the module at http://sourceforge.net/projects/video-2-1394/

Nobody else posted specific requirements so far. So let's clean up the 
API. How about this:
  - Determine a date or event at which unused symbols and functions will
    vanish. ("Unused": Not used by the mainline drivers and video-2-1394
    or any other project of similar scope of which the linux1394
    maintainers are informed soon enough.)
  - Add an according entry to Documentation/feature-removal-schedule.txt.
  - Add warning comments next to obsolete EXPORT_SYMBOLs. Add warning
    printks to obsolete functions? (If there are any.)
Are there proposals for a date? How about end of June?
-- 
Stefan Richter
-=====-=-=-= -=-- ==-==
http://arcgraph.de/sr/

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Adrian Bunk]

On Wed, Apr 27, 2005 at 11:11:59PM +0200, Stefan Richter wrote:
> Dan Dennedy wrote on 2005-04-20:
> >There are technical
> >merits for removal of the external symbols that I accept. I also accept
> >that we have no way of maintaining any sort of stable subsystem for
> >external projects we are not aware of or who are not communicating with
> >us about their requirements (it goes beyond just a stable interface).
> ...
> >I vote to remove external symbols not used by the Linux1394.org modules
> >or the module at http://sourceforge.net/projects/video-2-1394/
> 
> Nobody else posted specific requirements so far. So let's clean up the 
> API. How about this:
>  - Determine a date or event at which unused symbols and functions will
>    vanish. ("Unused": Not used by the mainline drivers and video-2-1394
>    or any other project of similar scope of which the linux1394
>    maintainers are informed soon enough.)

OK.

>  - Add an according entry to Documentation/feature-removal-schedule.txt.

OK.

>  - Add warning comments next to obsolete EXPORT_SYMBOLs. Add warning
>    printks to obsolete functions? (If there are any.)

OK.

> Are there proposals for a date? How about end of June?

OK (now it's perhaps beginning of Juli).


Is this OK for everyone?
If yes, I can prepare a patch.


> Stefan Richter

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] drivers/ieee1394/: remove unneeded EXPORT_SYMBOL's

[Stefan Richter]

Adrian Bunk wrote:
> Is this OK for everyone?
> If yes, I can prepare a patch.

I think it is finally time to do so. I even wanted to prepare a patch 
but got distracted...
-- 
Stefan Richter
-=====-=-=-= -=-= -==-=
http://arcgraph.de/sr/

[2.6 patch] drivers/ieee1394/: schedule unused EXPORT_SYMBOL's for removal

[Adrian Bunk]

On Fri, May 13, 2005 at 01:24:32AM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> >Is this OK for everyone?
> >If yes, I can prepare a patch.
> 
> I think it is finally time to do so. I even wanted to prepare a patch 
> but got distracted...

Patch below.

> Stefan Richter

cu
Adrian


<--  snip  -->


This patch schedules unused EXPORT_SYMBOL's for removal.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 Documentation/feature-removal-schedule.txt |   21 ++++++++++++++
 drivers/ieee1394/ieee1394_core.c           |   31 +++++++++++++++++++++
 2 files changed, 52 insertions(+)

--- linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt.old	2005-05-13 15:19:54.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/Documentation/feature-removal-schedule.txt	2005-05-13 15:29:24.000000000 +0200
@@ -93,0 +94,21 @@
+
+---------------------------
+
+What:	remove the following ieee1394 EXPORT_SYMBOL's:
+	- hpsb_send_phy_config
+	- hpsb_send_packet_and_wait
+	- highlevel_add_host
+	- highlevel_remove_host
+	- nodemgr_for_each_host
+	- csr1212_create_csr
+	- csr1212_init_local_csr
+	- csr1212_new_immediate
+	- csr1212_associate_keyval
+	- csr1212_new_string_descriptor_leaf
+	- csr1212_destroy_csr
+	- csr1212_generate_csr_image
+	- csr1212_parse_csr
+When:	July 2005
+Files:	drivers/ieee1394/ieee1394_core.c
+Why:	No modular usage in the kernel.
+Who:	Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c.old	2005-05-13 15:19:34.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/drivers/ieee1394/ieee1394_core.c	2005-05-13 15:28:17.000000000 +0200
@@ -1226,7 +1226,13 @@
 EXPORT_SYMBOL(hpsb_alloc_packet);
 EXPORT_SYMBOL(hpsb_free_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_phy_config);
+
 EXPORT_SYMBOL(hpsb_send_packet);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(hpsb_send_packet_and_wait);
+
 EXPORT_SYMBOL(hpsb_reset_bus);
 EXPORT_SYMBOL(hpsb_bus_reset);
@@ -1265,6 +1271,11 @@
 EXPORT_SYMBOL(hpsb_get_hostinfo_bykey);
 EXPORT_SYMBOL(hpsb_set_hostinfo);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_add_host);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(highlevel_remove_host);
+
 EXPORT_SYMBOL(highlevel_host_reset);
 
@@ -1275,4 +1286,6 @@
 EXPORT_SYMBOL(hpsb_unregister_protocol);
 EXPORT_SYMBOL(ieee1394_bus_type);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(nodemgr_for_each_host);
 
@@ -1312,18 +1325,36 @@
 
 /** csr1212.c **/
+
+/* EXPORT_SYMBOLs scheduled for removal */
 EXPORT_SYMBOL(csr1212_create_csr);
 EXPORT_SYMBOL(csr1212_init_local_csr);
 EXPORT_SYMBOL(csr1212_new_immediate);
+
 EXPORT_SYMBOL(csr1212_new_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_associate_keyval);
+
 EXPORT_SYMBOL(csr1212_attach_keyval_to_directory);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_new_string_descriptor_leaf);
+
 EXPORT_SYMBOL(csr1212_detach_keyval_from_directory);
 EXPORT_SYMBOL(csr1212_release_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_destroy_csr);
+
 EXPORT_SYMBOL(csr1212_read);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_generate_csr_image);
+
 EXPORT_SYMBOL(csr1212_parse_keyval);
+
+/* EXPORT_SYMBOL scheduled for removal */
 EXPORT_SYMBOL(csr1212_parse_csr);
+
 EXPORT_SYMBOL(_csr1212_read_keyval);
 EXPORT_SYMBOL(_csr1212_destroy_keyval);