From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org
Cc: "Arjan van de Ven" <arjanv@infradead.org>,
mlindner@syskonnect.de, rroesler@syskonnect.de,
"Benoît Dejean" <benoit@placenet.org>
Subject: Re: [patch] reduce stack footprint of functions in drivers/net/sk98lin/skgepnmi.c
Date: Sun, 10 Jul 2005 17:24:06 +0200 [thread overview]
Message-ID: <20050710152406.GA29482@elte.hu> (raw)
In-Reply-To: <20050709140314.GA6786@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> this patch reduces the stack footprint of Vpd() from 1018 bytes to 28
> bytes, SkPnmiGetStruct() from 744 bytes to 92 bytes, GetVpdKeyArr()
> from 552 bytes to 48 bytes, and General() from 364 bytes to 112 bytes.
Benoît Dejean noticed that these changes are incorrect, because the code
deals with KeyArr as an array of strings (and a 2D array), while my
changes turn it into a char **. This breaks code like:
Ret = GetVpdKeyArr(pAC, IoC, &KeyArr[0][0], sizeof(KeyArr), &KeyNo);
...
if (SK_STRCMP(KeyStr, KeyArr[Index]) == 0) {
...
Ingo
prev parent reply other threads:[~2005-07-10 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-09 14:03 [patch] reduce stack footprint of functions in drivers/net/sk98lin/skgepnmi.c Ingo Molnar
2005-07-10 15:24 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050710152406.GA29482@elte.hu \
--to=mingo@elte.hu \
--cc=arjanv@infradead.org \
--cc=benoit@placenet.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@syskonnect.de \
--cc=rroesler@syskonnect.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox