Re: [PATCH] [37/48] Suspend2 2.1.9.8 for 2.6.12: 613-pageflags.patch

Pekka Enberg
2005-07-06T16:20:56Z

On 7/6/05, Nigel Cunningham <nigel@suspend2.net> wrote:
> diff -ruNp 614-plugins.patch-old/kernel/power/suspend2_core/plugins.c 614-plugins.patch-new/kernel/power/suspend2_core/plugins.c
> --- 614-plugins.patch-old/kernel/power/suspend2_core/plugins.c 1970-01-01 10:00:00.000000000 +1000
> +++ 614-plugins.patch-new/kernel/power/suspend2_core/plugins.c 2005-07-04 23:14:19.000000000 +1000
> @@ -0,0 +1,341 @@
> +#define FILTER_PLUGIN 1
> +#define WRITER_PLUGIN 2
> +#define MISC_PLUGIN 4 // Block writer, eg.
> +#define CHECKSUM_PLUGIN 5
> +
> +#define SUSPEND_ASYNC 0
> +#define SUSPEND_SYNC 1

Enums are preferred.

> +
> +#define SUSPEND_COMMON_IO_OPS \
> + /* Writing the image proper */ \
> + int (*write_chunk) (struct page * buffer_page); \
> +\
> + /* Reading the image proper */ \
> + int (*read_chunk) (struct page * buffer_page, int sync); \
> +\
> + /* Reset plugin if image exists but reading aborted */ \
> + void (*noresume_reset) (void);

Please remove the above macro obfuscation.