Re: [PATCH] [30/48] Suspend2 2.1.9.8 for 2.6.12: 607-atomic-copy.patch

Nigel Cunningham
2005-07-11T08:57:15Z

Hi.

On Mon, 2005-07-11 at 04:01, Pavel Machek wrote:
> Hi!
>
> > --- 608-compression.patch-old/kernel/power/suspend2_core/compression.c 1970-01-01 10:00:00.000000000 +1000
> > +++
> > 608-compression.patch-new/kernel/power/suspend2_core/compression.c
> ~~~~~~~~~~~~~
>
> suspend2_core looks like an extremely bad name for a directory... And
> this is really plugin, not a core, no? Plus it would be nice to drop
> non-essential stuff for initial submit, so that it is not *that* big
> to review.

Suspend2_core was just to keep things nicely separated for the moment.
I've already shifted everything into kernel/power after Pekka's email.

Regarding non essential stuff, the compression and encryption parts are
really quite small. LZF Compression doubles the speed, and encryption is
considered important by people who care about security. It also helps
you see why the plugin stuff is useful. Of course plugin isn't really
the right name anymore - it's more of an internal api.

Regards,

Nigel
--
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.