Re: [PATCH] [4/48] Suspend2 2.1.9.8 for 2.6.12: 302-init-hooks.patch

Nigel Cunningham
2005-07-06T11:04:04Z

Hi.

On Wed, 2005-07-06 at 18:38, Shaohua Li wrote:
> On Wed, 2005-07-06 at 12:20 +1000, Nigel Cunningham wrote:
> > diff -ruNp 350-workthreads.patch-old/drivers/acpi/osl.c 350-workthreads.patch-new/drivers/acpi/osl.c
> > --- 350-workthreads.patch-old/drivers/acpi/osl.c 2005-06-20 11:46:50.000000000 +1000
> > +++ 350-workthreads.patch-new/drivers/acpi/osl.c 2005-07-04 23:14:18.000000000 +1000
> > @@ -95,7 +95,7 @@ acpi_os_initialize1(void)
> > return AE_NULL_ENTRY;
> > }
> > #endif
> > - kacpid_wq = create_singlethread_workqueue("kacpid");
> > + kacpid_wq = create_singlethread_workqueue("kacpid", PF_NOFREEZE);
> > BUG_ON(!kacpid_wq);
> I'm not sure but kacpid can run any kind of code (depends on BIOS, it
> might touch some devices), is this safe?

If it's not, then we definitely want this patch as all workqueues are
NOFREEZE at the moment.

Regards,

Nigel
--
Evolution.
Enumerate the requirements.
Consider the interdependencies.
Calculate the probabilities.
Be amazed that people believe it happened.