public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Linux Kernel list <linux-kernel@vger.kernel.org>,
	rmk+serial@arm.linux.org.uk
Subject: [patch 2.6.13-git] 8250 tweaks
Date: Mon, 11 Jul 2005 19:22:04 -0700	[thread overview]
Message-ID: <200507111922.04800.david-b@pacbell.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

Two small changes:  make the IRQ name less generic, and stop
whining about certain non-errors (details in the patch comments).
Please merge.

- Dave


[-- Attachment #2: 8250.patch --]
[-- Type: text/x-diff, Size: 1159 bytes --]

Make the 8250 UART driver register its IRQ using a label that's more
appropriate ... it's an 8250 UART, not one of dozens of other kind of
serial link (I2C, SPI, USB, McBSP, I2S, non-8250 UART, USART, SSP,
MicroWire, PS/2 kbd/mouse/touchpad, MCSI, HDQ/1-Wire, ... etc).

Also, make it stop whining when one of the platform serial ports has
been disabled, e.g. because a given board doesn't wire it out.

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>

--- o26.orig/drivers/serial/8250.c	2005-07-11 18:41:03.000000000 -0700
+++ o26/drivers/serial/8250.c	2005-07-11 18:58:26.000000000 -0700
@@ -1317,7 +1317,7 @@ static int serial_link_irq_chain(struct 
 		spin_unlock_irq(&i->lock);
 
 		ret = request_irq(up->port.irq, serial8250_interrupt,
-				  irq_flags, "serial", i);
+				  irq_flags, "uart_8250", i);
 		if (ret < 0)
 			serial_do_unlink(i, up);
 	}
@@ -2331,6 +2331,8 @@ static int __devinit serial8250_probe(st
 	memset(&port, 0, sizeof(struct uart_port));
 
 	for (i = 0; p && p->flags != 0; p++, i++) {
+		if (!p->iobase && !p->membase)
+			continue;
 		port.iobase	= p->iobase;
 		port.membase	= p->membase;
 		port.irq	= p->irq;

             reply	other threads:[~2005-07-12  3:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-12  2:22 David Brownell [this message]
2005-07-12  7:19 ` [patch 2.6.13-git] 8250 tweaks Russell King
2005-07-12  9:14   ` Russell King
2005-07-12 10:25   ` david-b
2005-07-12 11:08     ` Russell King
2005-07-12 11:32       ` david-b
2005-07-12 12:01         ` Russell King
2005-07-12 13:30           ` david-b
2005-07-12 14:00             ` Russell King
2005-07-13  4:55           ` Sam Song
2005-07-13  6:12             ` Russell King
2005-07-13 10:51               ` Sam Song
2005-07-13 12:48                 ` Russell King
2005-07-14  7:12                   ` Sam Song
2005-07-14 10:42                     ` Russell King
2005-07-15  5:11                       ` Sam Song
2005-07-16  8:43                         ` Russell King
2005-07-16 10:12                           ` Sam Song
2005-07-16 10:15                             ` Russell King
2005-07-16 12:31                               ` Sam Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200507111922.04800.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+serial@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox