* [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
@ 2005-07-13 18:41 Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2005-07-13 18:41 UTC (permalink / raw)
To: alexn, len.brown, acpi-devel
Cc: linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy.Dunlap, Chuck Wolber, torvalds, akpm,
alan
-stable review patch. If anyone has any objections, please let us know.
------------------
If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
That zero just means that nothing else found any irq information either.
Fixes http://bugme.osdl.org/show_bug.cgi?id=4824
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/acpi/pci_irq.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.12.2.orig/drivers/acpi/pci_irq.c 2005-07-13 10:53:01.000000000 -0700
+++ linux-2.6.12.2/drivers/acpi/pci_irq.c 2005-07-13 10:56:30.000000000 -0700
@@ -433,7 +433,7 @@
printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
pci_name(dev), ('A' + pin));
/* Interrupt Line values above 0xF are forbidden */
- if (dev->irq >= 0 && (dev->irq <= 0xF)) {
+ if (dev->irq > 0 && (dev->irq <= 0xF)) {
printk(" - using IRQ %d\n", dev->irq);
acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
return_VALUE(0);
^ permalink raw reply [flat|nested] 2+ messages in thread* [00/11] -stable review
@ 2005-07-13 18:41 Greg KH
2005-07-13 18:43 ` [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Greg KH @ 2005-07-13 18:41 UTC (permalink / raw)
To: linux-kernel, stable
Cc: Justin Forbes, Zwane Mwaikambo, Theodore Ts'o, Randy Dunlap,
Chuck Wolber, torvalds, akpm, alan
This is the start of the stable review cycle for the 2.6.12.3 release.
There are 11 patches in this series, all will be posted as a response to
this one. If anyone has any issues with these being applied, please let
us know. If anyone is a maintainer of the proper subsystem, and wants
to add a signed-off-by: line to the patch, please respond with it.
These patches are sent out with a number of different people on the Cc:
line. If you wish to be a reviewer, please email stable@kernel.org to
add your name to the list. If you want to be off the reviewer list,
also email us.
Responses should be made by Friday, July 15, 20:00:00 UTC 2005.
Anything received after that time, might be too late.
thanks,
the -stable release team
^ permalink raw reply [flat|nested] 2+ messages in thread
* [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
2005-07-13 18:41 [00/11] -stable review Greg KH
@ 2005-07-13 18:43 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2005-07-13 18:43 UTC (permalink / raw)
To: alexn, len.brown, acpi-devel
Cc: linux-kernel, stable, Justin Forbes, Zwane Mwaikambo,
Theodore Ts'o, Randy.Dunlap, Chuck Wolber, torvalds, akpm,
alan
[resend to get threading correct, sorry]
-stable review patch. If anyone has any objections, please let us know.
------------------
If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq.
That zero just means that nothing else found any irq information either.
Fixes http://bugme.osdl.org/show_bug.cgi?id=4824
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/acpi/pci_irq.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.12.2.orig/drivers/acpi/pci_irq.c 2005-07-13 10:53:01.000000000 -0700
+++ linux-2.6.12.2/drivers/acpi/pci_irq.c 2005-07-13 10:56:30.000000000 -0700
@@ -433,7 +433,7 @@
printk(KERN_WARNING PREFIX "PCI Interrupt %s[%c]: no GSI",
pci_name(dev), ('A' + pin));
/* Interrupt Line values above 0xF are forbidden */
- if (dev->irq >= 0 && (dev->irq <= 0xF)) {
+ if (dev->irq > 0 && (dev->irq <= 0xF)) {
printk(" - using IRQ %d\n", dev->irq);
acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
return_VALUE(0);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-13 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-13 18:41 [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-07-13 18:41 [00/11] -stable review Greg KH
2005-07-13 18:43 ` [01/11] If ACPI doesn't find an irq listed, don't accept 0 as a valid PCI irq Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox