public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix subarchitecture EXPORT_SYMBOL breakage caused by i386_ksym reduction
@ 2005-07-13 13:38 James Bottomley
  2005-07-14 15:01 ` [PATCH] visws: reexport pm_power_off Alexey Dobriyan
  0 siblings, 1 reply; 2+ messages in thread
From: James Bottomley @ 2005-07-13 13:38 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton, Alexey Dobriyan; +Cc: Linux Kernel

This patch:

[PATCH] Remove i386_ksyms.c, almost

made files like smp.c do their own EXPORT_SYMBOLS.  This means that all
subarchitectures that override these symbols now have to do the exports
themselves.  This patch adds the exports for voyager (which is the most
affected since it has a separate smp harness).  However, someone should
audit all the other subarchitectures to see if any others got broken.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

diff --git a/arch/i386/mach-voyager/voyager_basic.c b/arch/i386/mach-voyager/voyager_basic.c
--- a/arch/i386/mach-voyager/voyager_basic.c
+++ b/arch/i386/mach-voyager/voyager_basic.c
@@ -36,6 +36,7 @@
  * Power off function, if any
  */
 void (*pm_power_off)(void);
+EXPORT_SYMBOL(pm_power_off);
 
 int voyager_level = 0;
 
diff --git a/arch/i386/mach-voyager/voyager_smp.c b/arch/i386/mach-voyager/voyager_smp.c
--- a/arch/i386/mach-voyager/voyager_smp.c
+++ b/arch/i386/mach-voyager/voyager_smp.c
@@ -10,6 +10,7 @@
  * the voyager hal to provide the functionality
  */
 #include <linux/config.h>
+#include <linux/module.h>
 #include <linux/mm.h>
 #include <linux/kernel_stat.h>
 #include <linux/delay.h>
@@ -40,6 +41,7 @@ static unsigned long cpu_irq_affinity[NR
 /* per CPU data structure (for /proc/cpuinfo et al), visible externally
  * indexed physically */
 struct cpuinfo_x86 cpu_data[NR_CPUS] __cacheline_aligned;
+EXPORT_SYMBOL(cpu_data);
 
 /* physical ID of the CPU used to boot the system */
 unsigned char boot_cpu_id;
@@ -72,6 +74,7 @@ static volatile unsigned long smp_invali
 /* Bitmask of currently online CPUs - used by setup.c for
    /proc/cpuinfo, visible externally but still physical */
 cpumask_t cpu_online_map = CPU_MASK_NONE;
+EXPORT_SYMBOL(cpu_online_map);
 
 /* Bitmask of CPUs present in the system - exported by i386_syms.c, used
  * by scheduler but indexed physically */
@@ -238,6 +241,7 @@ static cpumask_t smp_commenced_mask = CP
 /* This is for the new dynamic CPU boot code */
 cpumask_t cpu_callin_map = CPU_MASK_NONE;
 cpumask_t cpu_callout_map = CPU_MASK_NONE;
+EXPORT_SYMBOL(cpu_callout_map);
 
 /* The per processor IRQ masks (these are usually kept in sync) */
 static __u16 vic_irq_mask[NR_CPUS] __cacheline_aligned;
@@ -978,6 +982,7 @@ void flush_tlb_page(struct vm_area_struc
 
 	preempt_enable();
 }
+EXPORT_SYMBOL(flush_tlb_page);
 
 /* enable the requested IRQs */
 static void
@@ -1109,6 +1114,7 @@ smp_call_function (void (*func) (void *i
 
 	return 0;
 }
+EXPORT_SYMBOL(smp_call_function);
 
 /* Sorry about the name.  In an APIC based system, the APICs
  * themselves are programmed to send a timer interrupt.  This is used



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] visws: reexport pm_power_off
  2005-07-13 13:38 [PATCH] fix subarchitecture EXPORT_SYMBOL breakage caused by i386_ksym reduction James Bottomley
@ 2005-07-14 15:01 ` Alexey Dobriyan
  0 siblings, 0 replies; 2+ messages in thread
From: Alexey Dobriyan @ 2005-07-14 15:01 UTC (permalink / raw)
  To: Andrew Morton; +Cc: James Bottomley, Linus Torvalds, linux-kernel

On Wednesday 13 July 2005 17:38, James Bottomley wrote:
> [PATCH] Remove i386_ksyms.c, almost
> 
> made files like smp.c do their own EXPORT_SYMBOLS.  This means that all
> subarchitectures that override these symbols now have to do the exports
> themselves.  This patch adds the exports for voyager (which is the most
> affected since it has a separate smp harness).  However, someone should
> audit all the other subarchitectures to see if any others got broken.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 arch/i386/mach-visws/reboot.c |    1 +
 1 files changed, 1 insertion(+)

--- linux-vanilla/arch/i386/mach-visws/reboot.c	2005-07-13 19:45:59.000000000 +0400
+++ linux-visws/arch/i386/mach-visws/reboot.c	2005-07-14 18:53:23.000000000 +0400
@@ -7,6 +7,7 @@
 #include "piix4.h"
 
 void (*pm_power_off)(void);
+EXPORT_SYMBOL(pm_power_off);
 
 void machine_restart(char * __unused)
 {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-07-14 14:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-13 13:38 [PATCH] fix subarchitecture EXPORT_SYMBOL breakage caused by i386_ksym reduction James Bottomley
2005-07-14 15:01 ` [PATCH] visws: reexport pm_power_off Alexey Dobriyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox