Re: [PATCH 2.6.13-rc2-mm2 2/7] v9fs: VFS file, dentry, and directory operations (2.0.2)

Eric Van Hensbergen
2005-07-14T20:20:27Z

Doh! Good catch, I'll fix and resubmit - same goes for the formating issues.

On 7/14/05, Christoph Hellwig <hch@infradead.org> wrote:
> > @@ -383,9 +379,10 @@ v9fs_file_write(struct file *filp, const
> > return -ENOMEM;
> >
> > ret = copy_from_user(buffer, data, count);
> > - if (ret)
> > + if (ret) {
> > dprintk(DEBUG_ERROR, "Problem copying from user\n");
> > - else
> > + return -EFAULT;
> > + } else
> > ret = v9fs_write(filp, buffer, count, offset);
> >
> > kfree(buffer);
>
> Aren't you leaking buffer in the error case? Also we Linux people really
> hate an else clause when the if block contains a return statement ;-)
>
>