* [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
@ 2005-07-15 21:35 Adrian Bunk
2005-07-15 22:29 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-07-15 21:35 UTC (permalink / raw)
To: Andrew Morton; +Cc: John Klar, linux-kernel, mchehab, video4linux-list
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 9 Jul 2005
- 19 Apr 2005
drivers/media/video/tveeprom.c | 6 ++++--
include/media/tveeprom.h | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19 01:41:24.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19 01:41:28.000000000 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old 2005-04-19 01:40:39.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c 2005-04-19 01:41:13.000000000 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* ----------------------------------------------------------------------- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
2005-07-15 21:35 [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups Adrian Bunk
@ 2005-07-15 22:29 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2005-07-15 22:29 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Andrew Morton, John Klar, linux-kernel, video4linux-list
Adrian,
Your patch is at my personal TODO list.
We had lots of patches for 2.6.13, with some sigificative enhancements.
Unfortunatelly, your patch from 19 Apr 2005 was not applied, maybe
because you've sent during a period where V4L was Orphaned.
We've decided to stop non-bug fixes just some days before your newer
attempt (July, 7) to focus on more tests at a stable branch. Until July,
18, V4L are applying only bug fixes. After that, we'll collect more
patches at V4L and, maybe at the end of the next week, we'll send the
patchsets, including yours (It will be #1 :-) ).
Cheers,
Mauro.
Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make two needlessly global structs static
> - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> This patch was already sent on:
> - 9 Jul 2005
> - 19 Apr 2005
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
@ 2005-07-09 3:07 Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-07-09 3:07 UTC (permalink / raw)
To: Andrew Morton; +Cc: John Klar, linux-kernel, mchehab, video4linux-list
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 19 Apr 2005
drivers/media/video/tveeprom.c | 6 ++++--
include/media/tveeprom.h | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19 01:41:24.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19 01:41:28.000000000 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old 2005-04-19 01:40:39.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c 2005-04-19 01:41:13.000000000 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* ----------------------------------------------------------------------- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
^ permalink raw reply [flat|nested] 6+ messages in thread* [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
@ 2005-04-19 0:53 Adrian Bunk
2005-04-19 7:53 ` Gerd Knorr
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-04-19 0:53 UTC (permalink / raw)
To: 2003 John Klar; +Cc: linux-kernel, kraxel, video4linux-list
This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/media/video/tveeprom.c | 6 ++++--
include/media/tveeprom.h | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h.old 2005-04-19 01:41:24.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/media/tveeprom.h 2005-04-19 01:41:28.000000000 +0200
@@ -20,4 +20,3 @@
unsigned char *eeprom_data);
int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
--- linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c.old 2005-04-19 01:40:39.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/media/video/tveeprom.c 2005-04-19 01:41:13.000000000 +0200
@@ -453,6 +453,7 @@
}
EXPORT_SYMBOL(tveeprom_read);
+#if 0
int tveeprom_dump(unsigned char *eedata, int len)
{
int i;
@@ -468,6 +469,7 @@
return 0;
}
EXPORT_SYMBOL(tveeprom_dump);
+#endif /* 0 */
/* ----------------------------------------------------------------------- */
/* needed for ivtv.sf.net at the moment. Should go away in the long */
@@ -484,7 +486,7 @@
};
I2C_CLIENT_INSMOD;
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
static int
tveeprom_command(struct i2c_client *client,
@@ -556,7 +558,7 @@
return 0;
}
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
.owner = THIS_MODULE,
.name = "tveeprom",
.id = I2C_DRIVERID_TVEEPROM,
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
2005-04-19 0:53 Adrian Bunk
@ 2005-04-19 7:53 ` Gerd Knorr
2005-05-01 14:23 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Gerd Knorr @ 2005-04-19 7:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: 2003 John Klar, linux-kernel, video4linux-list
> - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
That's a debug helper function, please don't drop it. #if 0 might be
ok, not sure though, the tveeprom module is also used by a out-of-kernel
driver (ivtv). Otherwise the patch looks fine to me.
Gerd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
2005-04-19 7:53 ` Gerd Knorr
@ 2005-05-01 14:23 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2005-05-01 14:23 UTC (permalink / raw)
To: Gerd Knorr; +Cc: 2003 John Klar, linux-kernel, video4linux-list
On Tue, Apr 19, 2005 at 09:53:48AM +0200, Gerd Knorr wrote:
> > - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
>
> That's a debug helper function, please don't drop it. #if 0 might be
> ok, not sure though, the tveeprom module is also used by a out-of-kernel
> driver (ivtv). Otherwise the patch looks fine to me.
As the comment says, my patch does #if 0 the function.
> Gerd
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-07-15 22:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-15 21:35 [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups Adrian Bunk
2005-07-15 22:29 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2005-07-09 3:07 Adrian Bunk
2005-04-19 0:53 Adrian Bunk
2005-04-19 7:53 ` Gerd Knorr
2005-05-01 14:23 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox