[patch] QLA2xxx FW_LOADER Kconfig issue results in undefined symbols

[patch] QLA2xxx FW_LOADER Kconfig issue results in undefined symbols

[Erik Jacobson]

I hit a small problem (first observed in 2.6.13-rc3-mm1) that resulted in
my kernels no longer building because of undefined references to 
request_firmware and release_firmware.

After a little research, I found that the QLA stuff requires CONFIG_FW_LOADER.

I was using the sn2_defconfig as a starting point for my config file. 
This config file compiles some of the QLA2xxx drivers statically.
By default, CONFIG_FW_LOADER is set to "m" and not "y".

So this small change should ensure CONFIG_FW_LOADER is set properly.

Perhaps there are better ways to do this?

Signed-off-by: Erik Jacobson <erikj@sgi.com>

---

 Kconfig |    1 +
 1 files changed, 1 insertion(+)


diff -Naru 2.6-akpm-rc-mm-orig/drivers/scsi/qla2xxx/Kconfig 2.6-akpm-rc-mm/drivers/scsi/qla2xxx/Kconfig
--- 2.6-akpm-rc-mm-orig/drivers/scsi/qla2xxx/Kconfig	2005-07-15 10:58:54.316985000 -0500
+++ 2.6-akpm-rc-mm/drivers/scsi/qla2xxx/Kconfig	2005-07-18 14:03:37.888758336 -0500
@@ -3,6 +3,7 @@
 	default (SCSI && PCI)
 	depends on SCSI && PCI
 	select SCSI_FC_ATTRS
+	select FW_LOADER
 
 config SCSI_QLA21XX
 	tristate "QLogic ISP2100 host adapter family support"

--
Erik Jacobson - Linux System Software - Silicon Graphics - Eagan, Minnesota

Re: [patch] QLA2xxx FW_LOADER Kconfig issue results in undefined symbols

[Adrian Bunk]

On Mon, Jul 18, 2005 at 02:23:57PM -0500, Erik Jacobson wrote:
> I hit a small problem (first observed in 2.6.13-rc3-mm1) that resulted in
> my kernels no longer building because of undefined references to 
> request_firmware and release_firmware.
> 
> After a little research, I found that the QLA stuff requires CONFIG_FW_LOADER.
> 
> I was using the sn2_defconfig as a starting point for my config file. 
> This config file compiles some of the QLA2xxx drivers statically.
> By default, CONFIG_FW_LOADER is set to "m" and not "y".
> 
> So this small change should ensure CONFIG_FW_LOADER is set properly.
> 
> Perhaps there are better ways to do this?
>...
> --- 2.6-akpm-rc-mm-orig/drivers/scsi/qla2xxx/Kconfig	2005-07-15 10:58:54.316985000 -0500
> +++ 2.6-akpm-rc-mm/drivers/scsi/qla2xxx/Kconfig	2005-07-18 14:03:37.888758336 -0500
> @@ -3,6 +3,7 @@
>  	default (SCSI && PCI)
>  	depends on SCSI && PCI
>  	select SCSI_FC_ATTRS
> +	select FW_LOADER
>  
>  config SCSI_QLA21XX
>  	tristate "QLogic ISP2100 host adapter family support"
>...
 
I have to resend my patch for this issue that didn't make it through the 
linux-kernel filters.

Your patch enables FW_LOADER for everyone with (SCSI && PCI) since is a 
not user-visible option that is enabled then.

The correct solution my patch does is to add a "select FW_LOADER" to 
every single of the driver options below.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed