Re: [PATCH] pci_find_device --> pci_get_device

Rolf Eike Beer
2005-07-19T16:19:33Z

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

Am Dienstag, 19. Juli 2005 17:44 schrieb Jiri Slaby:
>Rolf Eike Beer napsal(a):
>>Jiri Slaby wrote:
>>>Kernel version: 2.6.13-rc3-git4
>>>
>>>* This patch removes from kernel tree pci_find_device and changes
>>>it with pci_get_device. Next, it adds pci_dev_put, to decrease reference
>>>count of the variable.
>>>* Next, there are some (about 10 or so) gcc warning problems (i. e.
>>>variable may be unitialized) solutions, which were around code with old
>>>pci_find_device.
>>
>>Is this the reason why you initialize members of static structs? If this is
>>uninitialized it will end in the bss section and will be zeroed before the
>>kernel uses is. If you do it will go into data section and add more bloat
>> to the binary. At least this is the explanation I got once why not to do
>> this.
>
>I can't find now changes of initialization static variables, but i have
>deleted section
>dealing up with gcc warning from patch, it would go on a queue later.

Sorry, I misread the diff. That are static functions with the variables in
them, not static structs.

Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added
parts do not match in behaviour.

If you add braces after if's please add the '{' in the same line as the if
itself. This will make the diff bigger, but then this matches
Documentation/Coding-style.

Eike

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]