From: Adrian Bunk <bunk@stusta.de>
To: Bodo Eggert <7eggert@gmx.de>, perex@suse.cz
Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: [2.6 patch] sound drivers select'ing ISAPNP must depend on PNP && ISA
Date: Tue, 19 Jul 2005 18:36:40 +0200 [thread overview]
Message-ID: <20050719163640.GK5031@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0507171702030.12446@be1.lrz>
On Sun, Jul 17, 2005 at 05:07:48PM +0200, Bodo Eggert wrote:
> In sound/isa/Kconfig, select ISAPNP and depend on ISAPNP are intermixed,
> resulting in funny behaviour. (Soundcarts get selectable if other
> soundcards are selected).
>
> This patch changes the "depend on ISAPNP"s to select.
>...
I like the idea of this patch, but it brings to more drivers to a
violation of the "if you select something, you have to ensure that the
dependencies of what you select are fulfilled" rule causing link errors
with invalid .config's.
This patch (on top of your patch) fixes this problem.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
sound/isa/Kconfig | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
--- linux-2.6.13-rc3-mm1-full/sound/isa/Kconfig.old 2005-07-19 18:27:21.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/sound/isa/Kconfig 2005-07-19 18:28:44.000000000 +0200
@@ -15,7 +15,7 @@
config SND_AD1816A
tristate "Analog Devices SoundPort AD1816A"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
@@ -81,7 +81,7 @@
config SND_ES968
tristate "Generic ESS ES968 driver"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_MPU401_UART
select SND_PCM
@@ -162,7 +162,7 @@
config SND_INTERWAVE
tristate "AMD InterWave, Gravis UltraSound PnP"
- depends on SND
+ depends on SND && PNP && ISA
select SND_RAWMIDI
select SND_CS4231_LIB
select SND_GUS_SYNTH
@@ -177,7 +177,7 @@
config SND_INTERWAVE_STB
tristate "AMD InterWave + TEA6330T (UltraSound 32-Pro)"
- depends on SND
+ depends on SND && PNP && ISA
select SND_RAWMIDI
select SND_CS4231_LIB
select SND_GUS_SYNTH
@@ -293,7 +293,7 @@
config SND_ALS100
tristate "Avance Logic ALS100/ALS120"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
@@ -307,7 +307,7 @@
config SND_AZT2320
tristate "Aztech Systems AZT2320"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
@@ -332,7 +332,7 @@
config SND_DT019X
tristate "Diamond Technologies DT-019X, Avance Logic ALS-007"
- depends on SND
+ depends on SND && PNP && ISA
select ISAPNP
select SND_OPL3_LIB
select SND_MPU401_UART
next prev parent reply other threads:[~2005-07-19 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-17 15:07 [PATCH] use select in sound/isa/Kconfig Bodo Eggert
2005-07-19 16:36 ` Adrian Bunk [this message]
2005-07-19 20:50 ` [2.6 patch] sound drivers select'ing ISAPNP must depend on PNP && ISA Bodo Eggert
2005-07-23 16:48 ` Adrian Bunk
2005-07-24 9:39 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050719163640.GK5031@stusta.de \
--to=bunk@stusta.de \
--cc=7eggert@gmx.de \
--cc=akpm@osdl.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox