From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261512AbVGSQgr (ORCPT ); Tue, 19 Jul 2005 12:36:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261578AbVGSQgr (ORCPT ); Tue, 19 Jul 2005 12:36:47 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:45066 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261512AbVGSQgr (ORCPT ); Tue, 19 Jul 2005 12:36:47 -0400 Date: Tue, 19 Jul 2005 18:36:40 +0200 From: Adrian Bunk To: Bodo Eggert <7eggert@gmx.de>, perex@suse.cz Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: [2.6 patch] sound drivers select'ing ISAPNP must depend on PNP && ISA Message-ID: <20050719163640.GK5031@stusta.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 17, 2005 at 05:07:48PM +0200, Bodo Eggert wrote: > In sound/isa/Kconfig, select ISAPNP and depend on ISAPNP are intermixed, > resulting in funny behaviour. (Soundcarts get selectable if other > soundcards are selected). > > This patch changes the "depend on ISAPNP"s to select. >... I like the idea of this patch, but it brings to more drivers to a violation of the "if you select something, you have to ensure that the dependencies of what you select are fulfilled" rule causing link errors with invalid .config's. This patch (on top of your patch) fixes this problem. Signed-off-by: Adrian Bunk --- sound/isa/Kconfig | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) --- linux-2.6.13-rc3-mm1-full/sound/isa/Kconfig.old 2005-07-19 18:27:21.000000000 +0200 +++ linux-2.6.13-rc3-mm1-full/sound/isa/Kconfig 2005-07-19 18:28:44.000000000 +0200 @@ -15,7 +15,7 @@ config SND_AD1816A tristate "Analog Devices SoundPort AD1816A" - depends on SND + depends on SND && PNP && ISA select ISAPNP select SND_OPL3_LIB select SND_MPU401_UART @@ -81,7 +81,7 @@ config SND_ES968 tristate "Generic ESS ES968 driver" - depends on SND + depends on SND && PNP && ISA select ISAPNP select SND_MPU401_UART select SND_PCM @@ -162,7 +162,7 @@ config SND_INTERWAVE tristate "AMD InterWave, Gravis UltraSound PnP" - depends on SND + depends on SND && PNP && ISA select SND_RAWMIDI select SND_CS4231_LIB select SND_GUS_SYNTH @@ -177,7 +177,7 @@ config SND_INTERWAVE_STB tristate "AMD InterWave + TEA6330T (UltraSound 32-Pro)" - depends on SND + depends on SND && PNP && ISA select SND_RAWMIDI select SND_CS4231_LIB select SND_GUS_SYNTH @@ -293,7 +293,7 @@ config SND_ALS100 tristate "Avance Logic ALS100/ALS120" - depends on SND + depends on SND && PNP && ISA select ISAPNP select SND_OPL3_LIB select SND_MPU401_UART @@ -307,7 +307,7 @@ config SND_AZT2320 tristate "Aztech Systems AZT2320" - depends on SND + depends on SND && PNP && ISA select ISAPNP select SND_OPL3_LIB select SND_MPU401_UART @@ -332,7 +332,7 @@ config SND_DT019X tristate "Diamond Technologies DT-019X, Avance Logic ALS-007" - depends on SND + depends on SND && PNP && ISA select ISAPNP select SND_OPL3_LIB select SND_MPU401_UART