From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Jiri Slaby <jirislaby@gmail.com>,
rth@twiddle.net, dhowells@redhat.com, kumar.gala@freescale.com,
davem@davemloft.net, mhw@wittsend.com,
Rogier Wolff <R.E.Wolff@bitwizard.nl>,
nils@kernelconcepts.de, cjtsai@ali.com.tw,
Lionel.Bouton@inet6.fr, benh@kernel.crashing.org,
mchehab@brturbo.com.br, laredo@gnu.org,
rbultje@ronald.bitfreak.net, middelin@polyware.nl, philb@gnu.org,
tim@cyberelk.net, campbell@torque.net, andrea@suse.de,
linux@advansys.com, mulix@mulix.org
Subject: Re: [PATCH] pci_find_device --> pci_get_device
Date: Wed, 20 Jul 2005 13:19:29 +0200 [thread overview]
Message-ID: <200507201319.42050@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <42DE2A31.7080505@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby:
>Rolf Eike Beer napsal(a):
>>Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added
>>parts do not match in behaviour.
>
>I can't still see the difference.
diff --git a/arch/sparc64/kernel/ebus.c b/arch/sparc64/kernel/ebus.c
--- a/arch/sparc64/kernel/ebus.c
+++ b/arch/sparc64/kernel/ebus.c
@@ -527,8 +527,15 @@ static struct pci_dev *find_next_ebus(st
{
struct pci_dev *pdev = start;
- do {
- pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
+ while (pdev = pci_get_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev))
+ if (pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
+ pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS)
+ break;
+
+ *is_rio_p = !!(pdev && (pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS));
+
+/* do { // BEFORE \/ AFTER ^
+ * pdev = pci_find_device(PCI_VENDOR_ID_SUN, PCI_ANY_ID, pdev);
if (pdev &&
(pdev->device == PCI_DEVICE_ID_SUN_EBUS ||
pdev->device == PCI_DEVICE_ID_SUN_RIO_EBUS))
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-07-20 11:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-19 0:25 [PATCH] pci_find_device --> pci_get_device Jiri Slaby
2005-07-19 4:36 ` Rogier Wolff
2005-07-19 10:53 ` Jiri Slaby
2005-07-19 11:15 ` Rogier Wolff
2005-07-19 11:27 ` Rolf Eike Beer
2005-07-19 15:44 ` Jiri Slaby
2005-07-19 16:20 ` Rolf Eike Beer
2005-07-20 10:40 ` Jiri Slaby
2005-07-20 11:19 ` Rolf Eike Beer [this message]
2005-07-20 12:05 ` Jiri Slaby
2005-07-20 13:56 ` Rolf Eike Beer
2005-07-20 14:40 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507201319.42050@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=Lionel.Bouton@inet6.fr \
--cc=R.E.Wolff@bitwizard.nl \
--cc=andrea@suse.de \
--cc=benh@kernel.crashing.org \
--cc=campbell@torque.net \
--cc=cjtsai@ali.com.tw \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=jirislaby@gmail.com \
--cc=kumar.gala@freescale.com \
--cc=laredo@gnu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@advansys.com \
--cc=mchehab@brturbo.com.br \
--cc=mhw@wittsend.com \
--cc=middelin@polyware.nl \
--cc=mulix@mulix.org \
--cc=nils@kernelconcepts.de \
--cc=philb@gnu.org \
--cc=rbultje@ronald.bitfreak.net \
--cc=rth@twiddle.net \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox