From: Adrian Bunk <bunk@stusta.de>
To: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/cdrom/mcdx.c: fix -Wundef warnings
Date: Fri, 22 Jul 2005 23:40:48 +0200 [thread overview]
Message-ID: <20050722214048.GV3160@stusta.de> (raw)
This patch fixes the following warnings with -Wundef:
<-- snip -->
...
CC drivers/cdrom/mcdx.o
drivers/cdrom/mcdx.c:54:5: warning: "RCS" is not defined
...
drivers/cdrom/mcdx.c:709:5: warning: "FALLBACK" is not defined
drivers/cdrom/mcdx.c:1219:5: warning: "WE_KNOW_WHY" is not defined
drivers/cdrom/mcdx.c:1297:5: warning: "FALLBACK" is not defined
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/cdrom/mcdx.c | 11 +++--------
1 files changed, 3 insertions(+), 8 deletions(-)
--- linux-2.6.13-rc3-mm1-full/drivers/cdrom/mcdx.c.old 2005-07-22 18:14:36.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/drivers/cdrom/mcdx.c 2005-07-22 18:15:29.000000000 +0200
@@ -51,11 +51,6 @@
*/
-#if RCS
-static const char *mcdx_c_version
- = "$Id: mcdx.c,v 1.21 1997/01/26 07:12:59 davem Exp $";
-#endif
-
#include <linux/module.h>
#include <linux/errno.h>
@@ -706,7 +701,7 @@
xtrace(OPENCLOSE, "open() init irq generation\n");
if (-1 == mcdx_config(stuffp, 1))
return -EIO;
-#if FALLBACK
+#ifdef FALLBACK
/* Set the read speed */
xwarn("AAA %x AAA\n", stuffp->readcmd);
if (stuffp->readerrs)
@@ -1216,7 +1211,7 @@
}
-#if WE_KNOW_WHY
+#ifdef WE_KNOW_WHY
/* irq 11 -> channel register */
outb(0x50, stuffp->wreg_chn);
#endif
@@ -1294,7 +1289,7 @@
ans = mcdx_xfer(stuffp, p, sector, nr_sectors);
return ans;
-#if FALLBACK
+#ifdef FALLBACK
if (-1 == ans)
stuffp->readerrs++;
else
reply other threads:[~2005-07-22 21:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050722214048.GV3160@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox