* [2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef
@ 2005-07-22 21:47 Adrian Bunk
2005-07-23 21:07 ` Stefan Richter
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2005-07-22 21:47 UTC (permalink / raw)
To: linux1394-devel; +Cc: linux-kernel
This patch fixes the following warnings with -Wundef:
<-- snip -->
...
CC drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c:202:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
drivers/ieee1394/sbp2.c:207:7: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
drivers/ieee1394/sbp2.c:2053:6: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
drivers/ieee1394/sbp2.c:2623:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.13-rc3-mm1-full/drivers/ieee1394/sbp2.c.old 2005-07-22 18:19:38.000000000 +0200
+++ linux-2.6.13-rc3-mm1-full/drivers/ieee1394/sbp2.c 2005-07-22 18:20:32.000000000 +0200
@@ -171,10 +171,11 @@
/* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
/* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
/* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
+/* CONFIG_IEEE1394_SBP2_DEBUG: 0-2 */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
#ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
#define SBP2_ORB_DEBUG(fmt, args...) HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, ## args)
static u32 global_outstanding_command_orbs = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef
2005-07-22 21:47 [2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef Adrian Bunk
@ 2005-07-23 21:07 ` Stefan Richter
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Richter @ 2005-07-23 21:07 UTC (permalink / raw)
To: linux1394-devel, linux-kernel; +Cc: Adrian Bunk
On 22 Jul, Adrian Bunk wrote:
> drivers/ieee1394/sbp2.c:202:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
> drivers/ieee1394/sbp2.c:207:7: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
> drivers/ieee1394/sbp2.c:2053:6: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
> drivers/ieee1394/sbp2.c:2623:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
Here is a minimally improved version of the patch. I kept your sign-off.
- - - - - - - - - - - - 8< - - - - - - - - - - - -
sbp2: fix compiler warnings with -Wundef
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Index: linux-2.6.13-rc3/drivers/ieee1394/sbp2.c
===================================================================
--- linux-2.6.13-rc3/drivers/ieee1394/sbp2.c (revision 1316)
+++ linux-2.6.13-rc3/drivers/ieee1394/sbp2.c (working copy)
@@ -171,10 +171,12 @@
/* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
/* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
/* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
+/* increase to 1 for verbose logging, to 2 for even more logging */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
+
#ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
#define SBP2_ORB_DEBUG(fmt, args...) HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, ## args)
static u32 global_outstanding_command_orbs = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-23 21:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-22 21:47 [2.6 patch] drivers/ieee1394/sbp2.c: fix warnings with -Wundef Adrian Bunk
2005-07-23 21:07 ` Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox