From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Dave Airlie <airlied@gmail.com>
Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Pavel Machek <pavel@ucw.cz>,
Dmitry Torokhov <dtor_core@ameritech.net>,
linux-kernel@vger.kernel.org, Dave Airlie <airlied@linux.ie>
Subject: Re: fix suspend/resume irq request free for yenta..
Date: Sun, 24 Jul 2005 09:19:02 +0100 [thread overview]
Message-ID: <20050724091902.A4908@flint.arm.linux.org.uk> (raw)
In-Reply-To: <21d7e997050723154057d36290@mail.gmail.com>; from airlied@gmail.com on Sun, Jul 24, 2005 at 08:40:00AM +1000
On Sun, Jul 24, 2005 at 08:40:00AM +1000, Dave Airlie wrote:
> > > What if some other driver is sharing the IRQ, and requires IRQs to be
> > > enabled for the resume to complete?
>
> All drivers re-enable IRQs on their way back up in their resume code,
> they shouldn't be doing anything before that point..
I think you missed the point. If a driver resume method requires
to send some commands to the chip to restore it to the state it was
before it was suspended, and requires interrupts to complete that
operation.
This is quite possible if a device has child devices which will be
resumed after it has been resumed, and they share this interrupt.
This is why I think request_irq/free_irq is a better solution.
Alternatively, we need to go to a two stage resume model - 1st
stage to re-setup the devices such that they are in a quiescent
state, 2nd stage to complete.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-07-24 8:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-22 22:33 fix suspend/resume irq request free for yenta Dave Airlie
2005-07-22 23:16 ` Dmitry Torokhov
2005-07-23 0:29 ` Pavel Machek
2005-07-23 7:40 ` Russell King
2005-07-23 15:41 ` Zwane Mwaikambo
2005-07-23 22:40 ` Dave Airlie
2005-07-24 8:19 ` Russell King [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-23 23:46 Daniel Ritz
2005-07-26 5:44 Brown, Len
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050724091902.A4908@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox