From: Johannes Stezenbach <js@linuxtv.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Keith Owens <kaos@ocs.com.au>,
Chuck Ebbert <76306.1226@compuserve.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Adrian Bunk <bunk@stusta.de>
Subject: Re: Why build empty object files in drivers/media?
Date: Sun, 24 Jul 2005 19:29:47 +0200 [thread overview]
Message-ID: <20050724172947.GF20437@linuxtv.org> (raw)
In-Reply-To: <20050724085845.GA8018@mars.ravnborg.org>
On Sun, Jul 24, 2005 at 08:58:45AM +0000, Sam Ravnborg wrote:
> On Sun, Jul 24, 2005 at 04:10:13PM +1000, Keith Owens wrote:
> > >
> > >diff --git a/drivers/media/Makefile b/drivers/media/Makefile
> > >--- a/drivers/media/Makefile
> > >+++ b/drivers/media/Makefile
> > >@@ -2,4 +2,7 @@
> > > # Makefile for the kernel multimedia device drivers.
> > > #
> > >
> > >-obj-y := video/ radio/ dvb/ common/
> > >+obj-y := common/
> > >+obj-$(CONFIG_VIDEO_DEV) := video/
> > >+obj-$(CONFIG_VIDEO_DEV) := radio/
> > >+obj-$(CONFIG_DVB) := dvb/
> >
> > That should be +=, not :=
> >
> > +obj-$(CONFIG_VIDEO_DEV) += video/
> > +obj-$(CONFIG_VIDEO_DEV) += radio/
> > +obj-$(CONFIG_DVB) += dvb/
>
> Correct - thanks!
OK, I'll pick this up and put it in CVS.
Thanks,
Johannes
prev parent reply other threads:[~2005-07-24 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-22 3:06 Why build empty object files in drivers/media? Chuck Ebbert
2005-07-22 19:46 ` Sam Ravnborg
2005-07-22 21:18 ` Olaf Dietsche
2005-07-23 0:09 ` Sam Ravnborg
2005-07-24 6:10 ` Keith Owens
[not found] ` <20050724085845.GA8018@mars.ravnborg.org>
2005-07-24 17:29 ` Johannes Stezenbach [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050724172947.GF20437@linuxtv.org \
--to=js@linuxtv.org \
--cc=76306.1226@compuserve.com \
--cc=bunk@stusta.de \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox