From: Jens Axboe <axboe@suse.de>
To: Peter Osterlund <petero2@telia.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] kill bio->bi_set
Date: Tue, 26 Jul 2005 04:16:55 +0200 [thread overview]
Message-ID: <20050726021655.GA3085@suse.de> (raw)
In-Reply-To: <m37jfea0xu.fsf@telia.com>
On Tue, Jul 26 2005, Peter Osterlund wrote:
> Jens Axboe <axboe@suse.de> writes:
>
> > On Sat, Jul 23 2005, Peter Osterlund wrote:
> > > Jens Axboe <axboe@suse.de> writes:
> > >
> > > > Dunno why I didn't notice before, but ->bi_set is totally unnecessary
> > > > bloat of struct bio. Just define a proper destructor for the bio and it
> > > > already knows what bio_set it belongs too.
> > >
> > > This causes crashes on my computer.
> >
> > Did I neglect to mention it was untested? :)
> ...
> > Thanks, I'll go over these and submit a fixed version.
>
> I fixed this myself. The patch below is tested with dm-crypt on top of
> pktcdvd on top of usb-storage, and worked fine in my tests.
Thanks! I was travelling, so I didn't get to it myself.
--
Jens Axboe
prev parent reply other threads:[~2005-07-26 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-20 22:29 [PATCH] kill bio->bi_set Jens Axboe
2005-07-23 19:58 ` Peter Osterlund
2005-07-23 20:59 ` Jens Axboe
2005-07-26 0:03 ` Peter Osterlund
2005-07-26 2:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050726021655.GA3085@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox