From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@osdl.org>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu, linux-kernel@vger.kernel.org
Subject: Re: [patch] Support powering sharp zaurus sl-5500 LCD up and down
Date: Wed, 27 Jul 2005 12:05:53 +0200 [thread overview]
Message-ID: <20050727100553.GG4270@elf.ucw.cz> (raw)
In-Reply-To: <20050727030029.3bab4889.akpm@osdl.org>
Hi!
> > > > +/*
> > > > + * Backlight control code for Sharp Zaurus SL-5500
> > > > + *
> > > > + * Copyright 2005 John Lenz <lenz@cs.wisc.edu>
> > > > + * GPL v2
> > >
> > > Who is the maintainer for this stuff?
> >
> > I guess I'll maintain in.
> >
> > > > +static struct locomo_dev *locomolcd_dev = NULL;
> > >
> > > bah.
> >
> > Well, sa1100fb_lcd_power is not provide us with void * we could use,
> > and by definition you only have one frontlight in a PDA, so that
> > should be okay...
>
> "bah" means "there's no need to initialise this to NULL".
Okay, that's kind of easier to fix ;-). Done here, it will eventually
propagate.
Pavel
--
teflon -- maybe it is a trademark, but it should not be.
next prev parent reply other threads:[~2005-07-27 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 9:26 [patch] Support powering sharp zaurus sl-5500 LCD up and down Pavel Machek
2005-07-27 9:37 ` Andrew Morton
2005-07-27 9:50 ` Pavel Machek
2005-07-27 10:00 ` Andrew Morton
2005-07-27 10:05 ` Pavel Machek [this message]
2005-07-27 9:53 ` Pavel Machek
2005-07-27 10:06 ` Richard Purdie
2005-07-30 13:07 ` Pavel Machek
2005-08-01 21:23 ` John Lenz
2005-08-01 22:14 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050727100553.GG4270@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox