public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
	mj@ucw.cz, openib-general@openib.org
Subject: Re: [PATCH] arch/xx/pci: remap_pfn_range -> io_remap_pfn_range
Date: Wed, 27 Jul 2005 23:58:47 -0700	[thread overview]
Message-ID: <20050728065847.GA18003@suse.de> (raw)
In-Reply-To: <20050728064859.GA11644@mellanox.co.il>

On Thu, Jul 28, 2005 at 09:48:59AM +0300, Michael S. Tsirkin wrote:
> Quoting r. Greg KH <gregkh@suse.de>:
> > Subject: Re: [PATCH] arch/xx/pci: remap_pfn_range -> io_remap_pfn_range
> > 
> > On Tue, Jul 26, 2005 at 01:32:00AM +0300, Michael S. Tsirkin wrote:
> > > Greg, Martin, does the following make sense?
> > > If it does, should other architectures be updated as well?
> > > 
> > Hm, you do realize that io_remap_pfn_range() is the same thing as
> > remap_pfn_range() on i386, right?
> > 
> > So, why would this patch change anything?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> 
> It doesnt change any behaviour.
> Its a style issue I'm trying to fix: even in arch specific code, isnt it better
> to use a generic io_remap_pfn_range to map PCI memory?

As I said above, it's the same thing on i386.
But, if you are getting picky, you should fix all of the other arches
too, right?

Anyway, why change this, I don't really see the need.

thanks,

greg k-h

  reply	other threads:[~2005-07-28  6:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-25 22:32 [PATCH] arch/xx/pci: remap_pfn_range -> io_remap_pfn_range Michael S. Tsirkin
2005-07-28  4:26 ` Greg KH
2005-07-28  4:30   ` [openib-general] " Roland Dreier
2005-07-28  4:50     ` Greg KH
2005-07-28  6:48   ` Michael S. Tsirkin
2005-07-28  6:58     ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-07-28 11:57 [openib-general] " Ian Pratt
2005-07-28 16:17 ` Greg KH
2005-07-31  8:51   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050728065847.GA18003@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=mj@ucw.cz \
    --cc=mst@mellanox.co.il \
    --cc=openib-general@openib.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox