Re: [PATCH 2/4] Task notifier: Implement todo list in task_struct

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > Introduce a todo notifier in the task_struct so that a task can be told to do
> > certain things. Abuse the suspend hooks try_to_freeze, freezing and refrigerator
> > to establish checkpoints where the todo list is processed. This will break software
> > suspend (next patch fixes and cleans up software suspend).
> 
> Ugh, this conflicts with stuff in -mm tree rather badly... In part
> thanks to patch by you that was already applied.
> 
> I fixed up rejects manually (but probably lost fix or two in
> progress), and will test.
> 
> Uff, and then it breaks suspend completely:
> 
> Jul 28 23:21:12 amd kernel: Stopping tasks:
> =====================================Restarting tasks...khpsbpkt:
> received unexpected signal?!
> Jul 28 23:21:12 amd kernel: NodeMgr: received unexpected signal?!
> Jul 28 23:21:22 amd kernel:  done
> Jul 28 23:21:32 amd pam_limits[1547]: wrong limit value 'unlimited'
> 
> (Left me with basically all kernel threads going crazy:)
> 
> top - 23:22:34 up 3 min,  4 users,  load average: 5.10, 1.90, 0.69
> Tasks:  48 total,   2 running,  46 sleeping,   0 stopped,   0 zombie
> Cpu(s):  0.0% us, 100.0% sy,  0.0% ni,  0.0% id,  0.0% wa,  0.0% hi,
> 0.0% si
> Mem:   2064480k total,   155664k used,  1908816k free,    10280k
> buffers
> Swap:  2136448k total,        0k used,  2136448k free,   114624k
> cached
> 
>   PID USER      PR  NI  VIRT  RES  SHR S %CPU %MEM    TIME+  COMMAND
>   273 root      25   0     0    0    0 S 21.1  0.0   0:11.24 kswapd0
>   938 root      25   0     0    0    0 S 21.1  0.0   0:11.24 pccardd
>   940 root      25   0     0    0    0 S 21.1  0.0   0:11.30 pccardd
>  1060 root      25   0     0    0    0 R 21.1  0.0   0:21.34 kjournald
>  1409 root      25   0     0    0    0 S 17.3  0.0   0:19.71 kjournald
> 
> You are doing rather intrusive changes. Is testing them too much to
> ask? I'm pretty sure you can get i386 machine to test swsusp on...

(And yes, I did apply the whole series. It would be nice if next
series was relative to -mm, it already contains some of your changes).

								Pavel
-- 
teflon -- maybe it is a trademark, but it should not be.