public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Peterson <dsp@llnl.gov>
To: linux-kernel@vger.kernel.org
Cc: ak@suse.de
Subject: [PATCH] fix bug in x86_64 csum_partial_copy_generic()
Date: Fri, 29 Jul 2005 16:32:19 -0700	[thread overview]
Message-ID: <200507291632.19555.dsp@llnl.gov> (raw)

I was observing reproducible crashes on the "movw %bx,(%rsi)" instruction
below while a process in a recvfrom() system call was copying packet data
to user space.  The patch below fixes the exception table and causes the
crash to no longer reproduce.  Please apply.

Thanks,
Dave Peterson
<dsp@llnl.gov> <dave_peterson@pobox.com>

diff -urNp -X dontdiff linux-2.6.12.3/arch/x86_64/lib/csum-copy.S linux-2.6.12.3-bugfix/arch/x86_64/lib/csum-copy.S
--- linux-2.6.12.3/arch/x86_64/lib/csum-copy.S	2005-07-15 14:18:57.000000000 -0700
+++ linux-2.6.12.3-bugfix/arch/x86_64/lib/csum-copy.S	2005-07-29 16:06:47.000000000 -0700
@@ -188,8 +188,8 @@ csum_partial_copy_generic:
 	source
 	movw (%rdi),%bx
 	adcl %ebx,%eax
-	dest
 	decl %ecx
+	dest
 	movw %bx,(%rsi)
 	leaq 2(%rdi),%rdi
 	leaq 2(%rsi),%rsi

                 reply	other threads:[~2005-07-29 23:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200507291632.19555.dsp@llnl.gov \
    --to=dsp@llnl.gov \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox