public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix bug in x86_64 csum_partial_copy_generic()
@ 2005-07-29 23:32 Dave Peterson
  0 siblings, 0 replies; only message in thread
From: Dave Peterson @ 2005-07-29 23:32 UTC (permalink / raw)
  To: linux-kernel; +Cc: ak

I was observing reproducible crashes on the "movw %bx,(%rsi)" instruction
below while a process in a recvfrom() system call was copying packet data
to user space.  The patch below fixes the exception table and causes the
crash to no longer reproduce.  Please apply.

Thanks,
Dave Peterson
<dsp@llnl.gov> <dave_peterson@pobox.com>

diff -urNp -X dontdiff linux-2.6.12.3/arch/x86_64/lib/csum-copy.S linux-2.6.12.3-bugfix/arch/x86_64/lib/csum-copy.S
--- linux-2.6.12.3/arch/x86_64/lib/csum-copy.S	2005-07-15 14:18:57.000000000 -0700
+++ linux-2.6.12.3-bugfix/arch/x86_64/lib/csum-copy.S	2005-07-29 16:06:47.000000000 -0700
@@ -188,8 +188,8 @@ csum_partial_copy_generic:
 	source
 	movw (%rdi),%bx
 	adcl %ebx,%eax
-	dest
 	decl %ecx
+	dest
 	movw %bx,(%rsi)
 	leaq 2(%rdi),%rdi
 	leaq 2(%rsi),%rsi

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-07-29 23:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-29 23:32 [PATCH] fix bug in x86_64 csum_partial_copy_generic() Dave Peterson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox