From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [patch] ucb1x00: touchscreen cleanups
Date: Sat, 30 Jul 2005 10:17:44 +0100 [thread overview]
Message-ID: <20050730101744.A9652@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050726074627.GA11975@elf.ucw.cz>; from pavel@ucw.cz on Tue, Jul 26, 2005 at 09:46:27AM +0200
On Tue, Jul 26, 2005 at 09:46:27AM +0200, Pavel Machek wrote:
> @@ -55,20 +54,6 @@ struct ucb1x00_ts {
>
> static int adcsync;
>
> -static inline void ucb1x00_ts_evt_add(struct ucb1x00_ts *ts, u16 pressure, u16 x, u16 y)
> -{
> - input_report_abs(&ts->idev, ABS_X, x);
> - input_report_abs(&ts->idev, ABS_Y, y);
> - input_report_abs(&ts->idev, ABS_PRESSURE, pressure);
> - input_sync(&ts->idev);
> -}
> -
> -static inline void ucb1x00_ts_event_release(struct ucb1x00_ts *ts)
> -{
> - input_report_abs(&ts->idev, ABS_PRESSURE, 0);
> - input_sync(&ts->idev);
> -}
> -
Only one query: What's the reason for moving these? I think keeping
them makes the code more readable.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-07-30 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-26 7:46 [patch] ucb1x00: touchscreen cleanups Pavel Machek
2005-07-26 8:04 ` Mark Underwood
2005-07-26 8:07 ` Pavel Machek
2005-07-30 9:22 ` Russell King
2005-07-30 11:33 ` Mark Underwood
2005-07-30 20:28 ` Russell King
2005-07-30 20:46 ` Pavel Machek
2005-07-30 21:03 ` Russell King
2005-07-31 22:11 ` Mark Underwood
2005-07-31 22:33 ` Richard Purdie
2005-07-31 22:49 ` Pavel Machek
2005-08-01 8:02 ` How do we handle multi-function devices? [was Re: [patch] ucb1x00: touchscreen cleanups] Mark Underwood
2005-07-30 9:17 ` Russell King [this message]
2005-07-30 9:23 ` [patch] ucb1x00: touchscreen cleanups Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050730101744.A9652@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox