[PATCH] update maintainer for /dev/random

[PATCH] update maintainer for /dev/random

[Matt Mackall]

Ted has agreed to let me take over as maintainer of /dev/random and friends.
I've gone ahead and added a line to his entry in CREDITS.

Signed-off-by: Matt Mackall <mpm@selenic.com>

Index: mm/drivers/char/random.c
===================================================================
--- mm.orig/drivers/char/random.c	2005-04-06 13:41:34.000000000 -0700
+++ mm/drivers/char/random.c	2005-04-07 14:13:23.000000000 -0700
@@ -1,7 +1,7 @@
 /*
  * random.c -- A strong random number generator
  *
- * Version 1.89, last modified 19-Sep-99
+ * Copyright Matt Mackall <mpm@selenic.com>, 2003, 2004, 2005
  *
  * Copyright Theodore Ts'o, 1994, 1995, 1996, 1997, 1998, 1999.  All
  * rights reserved.
Index: mm/MAINTAINERS
===================================================================
--- mm.orig/MAINTAINERS	2005-04-06 13:42:21.000000000 -0700
+++ mm/MAINTAINERS	2005-04-07 14:13:23.000000000 -0700
@@ -1914,6 +1914,11 @@ M:	corey@world.std.com
 L:	linux-kernel@vger.kernel.org
 S:	Maintained
 
+RANDOM NUMBER DRIVER
+P:	Matt Mackall
+M:	mpm@selenic.com
+S:	Maintained
+
 REAL TIME CLOCK DRIVER
 P:	Paul Gortmaker
 M:	p_gortmaker@yahoo.com
Index: mm/CREDITS
===================================================================
--- mm.orig/CREDITS	2005-04-06 13:42:09.000000000 -0700
+++ mm/CREDITS	2005-04-07 14:13:25.000000000 -0700
@@ -3299,6 +3299,7 @@ D: Author of the new e2fsck
 D: Author of job control and system call restart code
 D: Author of ramdisk device driver
 D: Author of loopback device driver
+D: Author of /dev/random driver
 S: MIT Room E40-343
 S: 1 Amherst Street
 S: Cambridge, Massachusetts 02139


-- 
Mathematics is the supreme nostalgia of our time.

[PATCH] random : prefetch the whole pool, not 1/4 of it

[Eric Dumazet]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

Hi Matt

Could you check this patch and apply it ?

Thank you

Eric

[RANDOM] : prefetch the whole pool, not 1/4 of it,
            (pool contains u32 words, not bytes)

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>


[-- Attachment #2: patch.random --]
[-- Type: text/plain, Size: 375 bytes --]

--- linux-2.6.13-rc3/drivers/char/random.c	2005-07-13 06:46:46.000000000 +0200
+++ linux-2.6.13-rc3-ed/drivers/char/random.c	2005-07-29 00:11:24.000000000 +0200
@@ -469,7 +469,7 @@
 	next_w = *in++;
 
 	spin_lock_irqsave(&r->lock, flags);
-	prefetch_range(r->pool, wordmask);
+	prefetch_range(r->pool, wordmask*4);
 	input_rotate = r->input_rotate;
 	add_ptr = r->add_ptr;
 

Re: [PATCH] random : prefetch the whole pool, not 1/4 of it

[Matt Mackall]

On Fri, Jul 29, 2005 at 12:26:11AM +0200, Eric Dumazet wrote:
> Hi Matt
> 
> Could you check this patch and apply it ?
> 
> Thank you
> 
> Eric
> 
> [RANDOM] : prefetch the whole pool, not 1/4 of it,
>            (pool contains u32 words, not bytes)

You probably want r->poolinfo->poolwords as wordmask is off by one?
Please use "x * 4" rather than "x*4" too.


> --- linux-2.6.13-rc3/drivers/char/random.c	2005-07-13 06:46:46.000000000 +0200
> +++ linux-2.6.13-rc3-ed/drivers/char/random.c	2005-07-29 00:11:24.000000000 +0200
> @@ -469,7 +469,7 @@
>  	next_w = *in++;
>  
>  	spin_lock_irqsave(&r->lock, flags);
> -	prefetch_range(r->pool, wordmask);
> +	prefetch_range(r->pool, wordmask*4);
>  	input_rotate = r->input_rotate;
>  	add_ptr = r->add_ptr;
>  


-- 
Mathematics is the supreme nostalgia of our time.

Re: [PATCH] random : prefetch the whole pool, not 1/4 of it

[Folkert van Heusden]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

> Could you check this patch and apply it ?
> [RANDOM] : prefetch the whole pool, not 1/4 of it,
>            (pool contains u32 words, not bytes)
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>

> --- linux-2.6.13-rc3/drivers/char/random.c	2005-07-13 06:46:46.000000000 +0200
> +++ linux-2.6.13-rc3-ed/drivers/char/random.c	2005-07-29 00:11:24.000000000 +0200
> @@ -469,7 +469,7 @@
>  	next_w = *in++;
>  
>  	spin_lock_irqsave(&r->lock, flags);
> -	prefetch_range(r->pool, wordmask);
> +	prefetch_range(r->pool, wordmask*4);

Isn't it cleaner to replace the line above with:
+	prefetch_range(r->pool, wordmask * sizeof(__u32));
as the pool contains u32 words?

>  	input_rotate = r->input_rotate;
>  	add_ptr = r->add_ptr;
>  



Folkert van Heusden

-- 
Auto te koop, zie: http://www.vanheusden.com/daihatsu.php
--------------------------------------------------------------------
Get your PGP/GPG key signed at www.biglumber.com!
--------------------------------------------------------------------
Phone: +31-6-41278122, PGP-key: 1F28D8AE

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 282 bytes --]