From: "David S. Miller" <davem@davemloft.net>
To: dwalker@mvista.com
Cc: dada1@cosmosbay.com, linux-kernel@vger.kernel.org
Subject: Re: hashed spinlocks
Date: Sun, 31 Jul 2005 11:46:13 -0700 (PDT) [thread overview]
Message-ID: <20050731.114613.119242519.davem@davemloft.net> (raw)
In-Reply-To: <1122827276.18047.26.camel@c-67-188-6-232.hsd1.ca.comcast.net>
From: Daniel Walker <dwalker@mvista.com>
Date: Sun, 31 Jul 2005 09:27:55 -0700
> >From 2.6.13-rc4 this hunk
>
> +#else
> +# define rt_hash_lock_addr(slot) NULL
> +# define rt_hash_lock_init()
> +#endif
>
> Doesn't work with the following,
>
> + spin_unlock(rt_hash_lock_addr(i));
>
>
> Cause your spin locking a NULL .. I would give a patch, but I'm not sure
> what should be done in this case..
That spinlock debugging code is such a pain in the butt,
nothing at all should be happening with spinlocks on
a non-SMP build.
We should just change the route.c ifdef to check for
CONFIG_DEBUG_SPINLOCK as well as CONFIG_SMP, in order
to fix this.
next prev parent reply other threads:[~2005-07-31 18:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 22:07 Add prefetch switch stack hook in scheduler function Chen, Kenneth W
2005-07-27 23:13 ` Andrew Morton
2005-07-27 23:23 ` david mosberger
2005-07-28 7:41 ` Ingo Molnar
2005-07-28 8:09 ` Keith Owens
2005-07-28 8:16 ` Ingo Molnar
2005-07-28 9:09 ` Ingo Molnar
2005-07-28 19:14 ` Chen, Kenneth W
2005-07-29 7:04 ` Ingo Molnar
2005-07-29 7:07 ` Ingo Molnar
2005-07-29 8:30 ` Eric Dumazet
2005-07-29 8:44 ` Ingo Molnar
2005-07-31 16:27 ` hashed spinlocks Daniel Walker
2005-07-31 18:46 ` David S. Miller [this message]
2005-07-31 19:06 ` Daniel Walker
2005-07-31 19:11 ` David S. Miller
2005-07-31 19:16 ` Daniel Walker
2005-07-29 8:30 ` Add prefetch switch stack hook in scheduler function Chen, Kenneth W
2005-07-29 8:35 ` Ingo Molnar
2005-07-29 8:39 ` Chen, Kenneth W
2005-07-29 9:17 ` Peter Zijlstra
2005-07-29 10:52 ` Ingo Molnar
2005-07-29 7:22 ` Chen, Kenneth W
2005-07-29 7:45 ` Keith Owens
2005-07-29 8:02 ` Chen, Kenneth W
2005-07-29 8:28 ` Ingo Molnar
2005-07-29 9:02 ` Russell King
2005-07-29 9:45 ` Ingo Molnar
2005-07-29 7:38 ` Keith Owens
2005-07-29 8:08 ` Chen, Kenneth W
2005-07-28 8:31 ` Nick Piggin
2005-07-28 8:35 ` Ingo Molnar
2005-07-28 8:48 ` Nick Piggin
2005-07-28 9:16 ` Ingo Molnar
2005-07-28 9:19 ` Ingo Molnar
2005-07-28 9:34 ` Nick Piggin
2005-07-28 10:04 ` Ingo Molnar
2005-07-28 10:29 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050731.114613.119242519.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox