* [2.6 patch] jffs/jffs2: remove wrong function prototypes
@ 2005-07-31 17:00 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-07-31 17:00 UTC (permalink / raw)
To: dwmw2; +Cc: jffs-dev, linux-kernel
This patch removes prototypes for the generic_file_open and
generic_file_llseek functions.
Besides being superfluous because they are already present in fs.h, they
were also wrong because the actual functions aren't weak functions.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
fs/jffs/inode-v23.c | 3 ---
fs/jffs2/file.c | 3 ---
2 files changed, 6 deletions(-)
--- linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c.old 2005-07-31 18:43:46.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c 2005-07-31 18:44:15.000000000 +0200
@@ -1629,9 +1629,6 @@
}
-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *, loff_t, int) __attribute__((weak));
-
static struct file_operations jffs_file_operations =
{
.open = generic_file_open,
--- linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c.old 2005-07-31 18:44:31.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c 2005-07-31 18:44:40.000000000 +0200
@@ -21,9 +21,6 @@
#include <linux/jffs2.h>
#include "nodelist.h"
-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *file, loff_t offset, int origin) __attribute__((weak));
-
static int jffs2_commit_write (struct file *filp, struct page *pg,
unsigned start, unsigned end);
static int jffs2_prepare_write (struct file *filp, struct page *pg,
^ permalink raw reply [flat|nested] 2+ messages in thread* [2.6 patch] jffs/jffs2: remove wrong function prototypes
@ 2005-08-07 23:13 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-08-07 23:13 UTC (permalink / raw)
To: Andrew Morton; +Cc: dwmw2, jffs-dev, linux-kernel
This patch removes prototypes for the generic_file_open and
generic_file_llseek functions.
Besides being superfluous because they are already present in fs.h, they
were also wrong because the actual functions aren't weak functions.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 31 Jul 2005
fs/jffs/inode-v23.c | 3 ---
fs/jffs2/file.c | 3 ---
2 files changed, 6 deletions(-)
--- linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c.old 2005-07-31 18:43:46.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs/inode-v23.c 2005-07-31 18:44:15.000000000 +0200
@@ -1629,9 +1629,6 @@
}
-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *, loff_t, int) __attribute__((weak));
-
static struct file_operations jffs_file_operations =
{
.open = generic_file_open,
--- linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c.old 2005-07-31 18:44:31.000000000 +0200
+++ linux-2.6.13-rc4-mm1-full/fs/jffs2/file.c 2005-07-31 18:44:40.000000000 +0200
@@ -21,9 +21,6 @@
#include <linux/jffs2.h>
#include "nodelist.h"
-extern int generic_file_open(struct inode *, struct file *) __attribute__((weak));
-extern loff_t generic_file_llseek(struct file *file, loff_t offset, int origin) __attribute__((weak));
-
static int jffs2_commit_write (struct file *filp, struct page *pg,
unsigned start, unsigned end);
static int jffs2_prepare_write (struct file *filp, struct page *pg,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-08-07 23:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-31 17:00 [2.6 patch] jffs/jffs2: remove wrong function prototypes Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-08-07 23:13 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox