From: Jens Axboe <axboe@suse.de>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-2.6-block:master] block: fix cfq_find_next_crq
Date: Mon, 1 Aug 2005 15:17:51 +0200 [thread overview]
Message-ID: <20050801131750.GD22569@suse.de> (raw)
In-Reply-To: <20050726132706.GC23916@htj.dyndns.org>
On Tue, Jul 26 2005, Tejun Heo wrote:
> Hi,
>
> In cfq_find_next_crq(), when determining rbnext, if
> rb_next(&last->rb_node) is NULL, rb_first() is used without checking
> if it equals last. If it equals last, rbnext should be NULL not last.
> This bug is masked by duplicate calls to cfq_find_next_crq which ends
> up clearing cfqq->next_crq as, on the second call, last isn't on rb
> tree.
>
> This patch fixes cfq_find_next_crq() and removes extra calls to
> cfq_update_next_crq().
Thanks, looks good!
--
Jens Axboe
prev parent reply other threads:[~2005-08-01 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-26 13:27 [PATCH linux-2.6-block:master] block: fix cfq_find_next_crq Tejun Heo
2005-08-01 13:17 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050801131750.GD22569@suse.de \
--to=axboe@suse.de \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox