From: Ashok Raj <ashok.raj@intel.com>
To: Andi Kleen <ak@muc.de>
Cc: Ashok Raj <ashok.raj@intel.com>, Andrew Morton <akpm@osdl.org>,
zwane@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [patch 5/8] x86_64:Dont do broadcast IPIs when hotplug is enabled in flat mode.
Date: Thu, 4 Aug 2005 09:36:10 -0700 [thread overview]
Message-ID: <20050804093609.C15274@unix-os.sc.intel.com> (raw)
In-Reply-To: <20050804105107.GD97893@muc.de>; from ak@muc.de on Thu, Aug 04, 2005 at 12:51:07PM +0200
On Thu, Aug 04, 2005 at 12:51:07PM +0200, Andi Kleen wrote:
> > static void flat_send_IPI_allbutself(int vector)
> > {
> > +#ifndef CONFIG_HOTPLUG_CPU
> > if (((num_online_cpus()) - 1) >= 1)
> > __send_IPI_shortcut(APIC_DEST_ALLBUT, vector,APIC_DEST_LOGICAL);
> > +#else
> > + cpumask_t allbutme = cpu_online_map;
> > + int me = get_cpu(); /* Ensure we are not preempted when we clear */
> > + cpu_clear(me, allbutme);
> > + flat_send_IPI_mask(allbutme, vector);
> > + put_cpu();
>
> This still needs the num_online_cpus()s check.
Opps missed that... Thanks for spotting it.
I will send an updated one to Andrew.
--
Cheers,
Ashok Raj
- Open Source Technology Center
next prev parent reply other threads:[~2005-08-04 16:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 20:20 [patch 0/8] Updated patches for x86_64 Ashok Raj
2005-08-01 20:20 ` [patch 1/8] x86_64: Reintroduce clustered_apic_check() " Ashok Raj
2005-08-01 22:36 ` Ashok Raj
2005-08-01 20:20 ` [patch 2/8] x86_64: create sysfs entries for cpu only for present cpus Ashok Raj
2005-08-04 10:37 ` Andi Kleen
2005-08-01 20:20 ` [patch 3/8] x86_64:Dont call enforce_max_cpus when hotplug is enabled Ashok Raj
2005-08-04 10:41 ` Andi Kleen
2005-08-04 16:28 ` Ashok Raj
2005-08-01 20:20 ` [patch 4/8] x86_64:Fix cluster mode send_IPI_allbutself to use get_cpu()/put_cpu() Ashok Raj
2005-08-04 10:43 ` Andi Kleen
2005-08-04 16:33 ` Ashok Raj
2005-08-01 20:20 ` [patch 5/8] x86_64:Dont do broadcast IPIs when hotplug is enabled in flat mode Ashok Raj
2005-08-04 10:51 ` Andi Kleen
2005-08-04 16:36 ` Ashok Raj [this message]
2005-08-04 17:27 ` Ashok Raj
2005-08-01 20:20 ` [patch 6/8] x86_64:Dont use Lowest Priority when using physical mode Ashok Raj
2005-08-01 20:20 ` [patch 7/8] x86_64:Use common functions in cluster and physflat mode Ashok Raj
2005-08-01 20:20 ` [patch 8/8] x86_64: Choose physflat for AMD systems only when >8 CPUS Ashok Raj
2005-08-04 10:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050804093609.C15274@unix-os.sc.intel.com \
--to=ashok.raj@intel.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox