From: Dave Jones <davej@redhat.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Saripalli, Venkata Ramanamurthy (STSD)" <saripalli@hp.com>,
linux-scsi@vger.kernel.org, axboe@suse.de
Subject: Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel
Date: Thu, 4 Aug 2005 11:40:23 -0400 [thread overview]
Message-ID: <20050804154023.GA22886@redhat.com> (raw)
In-Reply-To: <200508041138.38216@bilbo.math.uni-mannheim.de>
On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote:
>
> >+ ulFibreFrame = kmalloc((2048/4), GFP_KERNEL);
> The size bug was already found by Dave Jones. This never should be written
> this way (not your fault). The array should have been [2048/sizeof(ULONG)].
wasteful. We only ever use 2048 bytes of this array, so doubling
its size on 64bit is pointless, unless you make changes later on
in the driver. (Which I think don't make sense, as we just copy
32 64byte chunks).
Ermm, actually this looks totally bogus..
CpqTsGetSFQEntry() ...
if( total_bytes <= 2048 )
{
memcpy( ulDestPtr,
&fcChip->SFQ->QEntry[consumerIndex],
64 ); // each SFQ entry is 64 bytes
ulDestPtr += 16; // advance pointer to next 64 byte block
}
we're trashing the last 48 bytes of every copy we make.
Does this driver even work ?
Dave
next prev parent reply other threads:[~2005-08-04 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-04 4:39 [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel Saripalli, Venkata Ramanamurthy (STSD)
2005-08-04 4:49 ` Dave Jones
2005-08-04 9:38 ` Rolf Eike Beer
2005-08-04 12:13 ` Denis Vlasenko
2005-08-04 15:40 ` Dave Jones [this message]
2005-08-04 15:56 ` Rolf Eike Beer
2005-08-04 16:42 ` Dave Jones
2005-08-04 17:11 ` Rolf Eike Beer
2005-08-04 17:38 ` Dave Jones
2005-08-04 13:53 ` Jesper Juhl
2005-08-06 1:13 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050804154023.GA22886@redhat.com \
--to=davej@redhat.com \
--cc=axboe@suse.de \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=saripalli@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox