public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, dipankar@in.ibm.com,
	rostedt@goodmis.org, bhuey@lnxw.com, shemminger@osdl.org,
	rusty@au1.ibm.com
Subject: Re: [RFC,PATCH] RCU and CONFIG_PREEMPT_RT sane patch
Date: Thu, 4 Aug 2005 09:50:55 -0700	[thread overview]
Message-ID: <20050804165054.GA1968@us.ibm.com> (raw)
In-Reply-To: <20050804144933.GB1297@us.ibm.com>

On Thu, Aug 04, 2005 at 07:49:33AM -0700, Paul E. McKenney wrote:
> On Thu, Aug 04, 2005 at 04:15:27PM +0200, Ingo Molnar wrote:
> > * Paul E. McKenney <paulmck@us.ibm.com> wrote:
> > 
> > Cool! I've merged your patch to the -52-12 version of the -RT patch. You 
> > can get it from the usual place:
> > 
> >   http://redhat.com/~mingo/realtime-preempt/
> > 
> > also, i've attached a port against 2.6.13-rc4. I have done this because 
> > the PREEMPT_RCU patch in my tree is applied before the core-PREEMPT_RT 
> > patch. I have fixed up the CONFIG_PREEMPT compilation branch and have 
> > removed your #error define - it built and booted fine on an UP box but 
> > there are no guarantees ...
> 
> Sounds great!!!  I will give it a thorough hammering in both the
> CONFIG_PREEMPT and CONFIG_PREEMPT_RT environments.

A couple of minor things thus far:

o	I get a linker error from V0.7.52-12:

	net/built-in.o(.init.text+0x898): In function `sock_aio_read':
	include/net/sock.h:625: undefined reference to `__you_cannot_kmalloc_that_much'

	This is not making much sense to me, since line 625 of sock.h
	is a small function with a container_of() as its only statement.
	The other other kmalloc() I can find in sock_aio_read() is
	allocating a "struct sock_iocb", which is certainly small enough
	for kmalloc() to handle.

	This may be a problem specific to the machine I compiled on,
	so am retrying on another.  Though that machine had absolutely
	no problem compiling and running V0.7.51-27...

	Enlightenment?

o	I messed up the #ifdefs for CONFIG_PREEMPT_RCU, CONFIG_RCU_STATS,
	and CONFIG_RCU_TORTURE_TEST so that it is not possible to build any
	of the following:

	1.	CONFIG_RCU_STATS without also CONFIG_RCU_TORTURE_TEST.

	2.	CONFIG_RCU_TORTURE_TEST without also CONFIG_RCU_STATS.

	3.	CONFIG_RCU_TORTURE_TEST without also CONFIG_PREEMPT_RCU.
		Which makes it tough to torture-test stock RCU.  ;-)

	Am checking out fixes for these, will post once I have untangled
	and tested.  Does not affect people who are not working directly
	on the RCU infrastructure itself.

							Thanx, Paul

      reply	other threads:[~2005-08-04 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01 17:11 [RFC,PATCH] RCU and CONFIG_PREEMPT_RT sane patch Paul E. McKenney
2005-08-04 14:15 ` Ingo Molnar
2005-08-04 14:49   ` Paul E. McKenney
2005-08-04 16:50     ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050804165054.GA1968@us.ibm.com \
    --to=paulmck@us.ibm.com \
    --cc=bhuey@lnxw.com \
    --cc=dipankar@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=rusty@au1.ibm.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox