From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262601AbVHDQdW (ORCPT ); Thu, 4 Aug 2005 12:33:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262602AbVHDQdW (ORCPT ); Thu, 4 Aug 2005 12:33:22 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:62737 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S262601AbVHDQc0 (ORCPT ); Thu, 4 Aug 2005 12:32:26 -0400 Date: Thu, 4 Aug 2005 17:32:16 +0100 From: Russell King To: Hugh Dickins Cc: Alexander Nyberg , Linus Torvalds , Nick Piggin , Martin Schwidefsky , Andrew Morton , Robin Holt , linux-kernel , linux-mm@kvack.org, Ingo Molnar , Roland McGrath , Andi Kleen Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug Message-ID: <20050804173215.I32154@flint.arm.linux.org.uk> Mail-Followup-To: Hugh Dickins , Alexander Nyberg , Linus Torvalds , Nick Piggin , Martin Schwidefsky , Andrew Morton , Robin Holt , linux-kernel , linux-mm@kvack.org, Ingo Molnar , Roland McGrath , Andi Kleen References: <42F09B41.3050409@yahoo.com.au> <20050804141457.GA1178@localhost.localdomain> <42F2266F.30008@yahoo.com.au> <20050804150053.GA1346@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from hugh@veritas.com on Thu, Aug 04, 2005 at 04:35:06PM +0100 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 04, 2005 at 04:35:06PM +0100, Hugh Dickins wrote: > And it does miss arm, the only arch which actually needs changing > right now, if we simply restore the original values which Nick shifted > - although arm references the VM_FAULT_ codes in some places, it also > uses "> 0". arm26 looks at first as if it needs changing too, but > a closer look shows it's remapping the faults and is okay - agreed? Your patch doesn't look right. Firstly, I'd rather stay away from switch() if at all possible - past experience has shown that it generates inherently poor code on ARM. Whether that's still true or not I've no idea, but I don't particularly want to find out at the moment. > Restore VM_FAULT_SIGBUS, VM_FAULT_MINOR and VM_FAULT_MAJOR to their > original values, so that arches which have them hardcoded will still > work before they're cleaned up. And correct arm to use the VM_FAULT_ > codes throughout, not assuming MINOR and MAJOR are the only ones > 0. And the above rules this out. As I say, I fixed ARM this morning, so changing these constants will break it again. Let's just wait for things to stabilise instead of trying to race with architecture maintainers... -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core