From: "David S. Miller" <davem@davemloft.net>
To: sandos@home.se
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
herbert@gondor.apana.org.au, akpm@osdl.org
Subject: Re: assertion (cnt <= tp->packets_out) failed
Date: Fri, 05 Aug 2005 09:32:08 -0700 (PDT) [thread overview]
Message-ID: <20050805.093208.74729918.davem@davemloft.net> (raw)
In-Reply-To: <42F38B67.5040308@home.se>
From: John Bäckstrand <sandos@home.se>
Date: Fri, 05 Aug 2005 17:53:11 +0200
> KERNEL: assertion (cnt <= tp->packets_out) failed at
> net/ipv4/tcp_input.c (1476)
I suspect this is a side effect of some changes Herbert Xu and
myself did to fix some other bugs.
Herbert, I think there are serious consequences for changing the
TSO counts for packets we have sent out already. This mucks up
all of the loss packet counts, which triggers asserts all over
in tcp_input.c
As you may note, we have all of this special code when we fragment
packets that updates all of the counters properly. And we're
not doing that for the new code that reinits the TSO count when
the MSS is found to no longer match.
It therefore may be desirable to keep Herbert's fix in there, but
back out my changes until they can be reimplemented correctly.
Herbert?
next prev parent reply other threads:[~2005-08-05 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 15:53 assertion (cnt <= tp->packets_out) failed John Bäckstrand
2005-08-05 16:32 ` David S. Miller [this message]
2005-08-06 2:24 ` Herbert Xu
2005-08-06 7:57 ` Herbert Xu
2005-08-06 12:06 ` John Bäckstrand
2005-08-07 12:02 ` Herbert Xu
2005-08-06 13:30 ` David S. Miller
2005-08-07 13:25 ` John Bäckstrand
2005-08-07 17:11 ` Andrew Morton
2005-08-07 21:30 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2005-08-07 16:20 Heikki Orsila
2005-08-07 16:29 Heikki Orsila
2005-08-07 16:37 Heikki Orsila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050805.093208.74729918.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sandos@home.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox